From 78f4ab6b89fca3086b9c9471b40c11c23fbb6142 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 14:12:40 -0700 Subject: [PATCH 01/16] Fix compiler warning about undefined ReinitializeRootWindow function --- hw/dmx/dmxextension.c | 3 --- include/dix.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/dmx/dmxextension.c b/hw/dmx/dmxextension.c index 24f796954..efcaca457 100644 --- a/hw/dmx/dmxextension.c +++ b/hw/dmx/dmxextension.c @@ -374,9 +374,6 @@ void dmxUpdateScreenResources(ScreenPtr pScreen, int x, int y, int w, int h) #ifdef PANORAMIX #include "panoramiXsrv.h" -/* Defined in dix/events.c */ -extern void ReinitializeRootWindow(WindowPtr win, int xoff, int yoff); - /** Change the "screen" window attributes by resizing the actual window * on the back-end display (if necessary). */ static void dmxConfigureScreenWindow(int idx, diff --git a/include/dix.h b/include/dix.h index 9fc5b07b3..7a4f49d4a 100644 --- a/include/dix.h +++ b/include/dix.h @@ -694,6 +694,9 @@ extern int TryClientEvents( extern void WindowsRestructured(void); +#ifdef PANORAMIX +extern void ReinitializeRootWindow(WindowPtr win, int xoff, int yoff); +#endif #ifdef RANDR void From 8e41640db884a4633b598d0a52b269e6547c8bf0 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 15:56:43 -0700 Subject: [PATCH 02/16] add bison generated files to .gitignore --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index b9396551e..0c144dd6e 100644 --- a/.gitignore +++ b/.gitignore @@ -30,3 +30,6 @@ include/xkb-config.h include/xorg-config.h include/xorg-server.h include/xwin-config.h +hw/dmx/config/parser.c +hw/dmx/config/parser.h +hw/dmx/config/scanner.c From 163980138cc0bfc9124456781b3dc45a49e2a129 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 16:11:20 -0700 Subject: [PATCH 03/16] remove some unused local variables in Xprint/Oid.c --- Xprint/Oid.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Xprint/Oid.c b/Xprint/Oid.c index 7cb1230c7..e4dadd519 100644 --- a/Xprint/Oid.c +++ b/Xprint/Oid.c @@ -1655,8 +1655,6 @@ TrayMediumListValidate(XpOidTrayMediumList* me, const XpOidMediumSS* msss) { int i_mss, i_ds, i_itm; - XpOidMediumDiscreteSizeList* ds_list; - int tray_count; XpOid current_tray, current_medium; XpOidMediumDiscreteSizeList* unspecified_tray_ds; XpOidMediumDiscreteSizeList* tray_ds; From 7a40ac2585028860730ffcd333eb3fe9de63680c Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 16:23:45 -0700 Subject: [PATCH 04/16] remove a bunch of unused variables in Xprint/Init.c (fixing the compiler warnings) --- Xprint/Init.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index 0bc1cf39e..cee9e47cf 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -288,10 +288,6 @@ static const char configFilePath[] = static const char printServerConfigDir[] = "XPSERVERCONFIGDIR"; -static int printScreenPrivIndex, - printWindowPrivIndex, - printGCPrivIndex; -static unsigned long printGeneration = 0; static char *configFileName = (char *)NULL; static Bool freeDefaultFontPath = FALSE; static char *origFontPath = (char *)NULL; @@ -806,7 +802,6 @@ GetConfigFileName(void) static PrinterDbPtr BuildPrinterDb(void) { - char *printerList, *augmentCmd = (char *)NULL; Bool defaultAugment = TRUE, freeConfigFileName; if(configFileName && access(configFileName, R_OK) != 0) @@ -1156,8 +1151,8 @@ AddToFontPath( static void AugmentFontPath(void) { - char *newPath, *modelID, **allIDs = (char **)NULL; - PrinterDbPtr pDb, pDbEntry; + char *modelID, **allIDs = (char **)NULL; + PrinterDbPtr pDbEntry; int numModels, i; if(!origFontPath) @@ -1649,10 +1644,9 @@ GenericScreenInit( int argc, char **argv) { - int i; float fWidth, fHeight, maxWidth, maxHeight; unsigned short width, height; - PrinterDbPtr pDb, pDb2; + PrinterDbPtr pDb; int res, maxRes; /* @@ -1799,7 +1793,7 @@ GetPrinterListInfo( int localeLen, char *locale) { - PrinterDbPtr pDb, pDb2; + PrinterDbPtr pDb; for(pDb = printerDb; pDb != (PrinterDbPtr)NULL; pDb = pDb->next) { @@ -1848,7 +1842,7 @@ XpDiGetPrinterList( if(!nameLen || name == (char *)NULL) { int i; - PrinterDbPtr pDb, pDb2; + PrinterDbPtr pDb; for(pDb = printerDb, i = 0; pDb != (PrinterDbPtr)NULL; pDb = pDb->next, i++) @@ -1898,7 +1892,6 @@ WindowPtr XpDiValidatePrinter(char *printerName, int printerNameLen) { PrinterDbPtr pCurEntry; - WindowPtr pWin; for(pCurEntry = printerDb; pCurEntry != (PrinterDbPtr)NULL; pCurEntry = pCurEntry->next) From 839305bac98856a2bb1d96691e4dcf49db229f90 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 19:12:23 -0700 Subject: [PATCH 05/16] Remove unused variables from Xprint/attributes.c --- Xprint/attributes.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Xprint/attributes.c b/Xprint/attributes.c index 60f6803a3..16724e4f8 100644 --- a/Xprint/attributes.c +++ b/Xprint/attributes.c @@ -342,7 +342,7 @@ BuildPrinterAttrs( if(systemAttributes.printers != (XrmDatabase)NULL) { - char *dirName, *fileName; + char *fileName; XrmDatabase modelDB = (XrmDatabase)NULL; XrmName xrm_name[5], xrm_class[2]; XrmRepresentation rep_type; @@ -642,7 +642,6 @@ XpGetOneAttribute( { ContextAttrPtr pCtxtAttrs; XrmDatabase db = (XrmDatabase)NULL; - char *retVal; XrmName xrm_name[3]; XrmRepresentation rep_type; XrmValue value; @@ -895,7 +894,6 @@ XpGetAttributes( { ContextAttrPtr pCtxtAttrs; XrmDatabase db = (XrmDatabase)NULL; - char *retVal; StringDbStruct enumStruct; XrmQuark empty = NULLQUARK; @@ -1536,8 +1534,8 @@ VectorizeCommand( char ***pVector, XpContextPtr pContext) { - char *cmdName, *curTok; - int i, numChars; + char *cmdName; + int numChars; if(command == (char *)NULL) return (char *)NULL; @@ -1563,7 +1561,7 @@ XpSubmitJob(fileName, pContext) char *fileName; XpContextPtr pContext; { - char **vector, *cmdNam, *cmdOpt, *command, *userName; + char **vector, *cmdNam, *command, *userName; int i; command = XpGetOneAttribute(pContext, XPPrinterAttr, "xp-spooler-command"); @@ -1689,7 +1687,6 @@ XpGetTrayMediumFromContext(XpContextPtr pCon, { char *defMedium, *defTray; char *t, *m; - char *pS, *pE, *pLast; defMedium = XpGetOneAttribute( pCon, XPPageAttr, "default-medium" ); From 71dd44b0ad617dd36ce4ed328f9e1e8c5ef713a5 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 7 Jun 2006 19:17:26 -0700 Subject: [PATCH 06/16] Fixed up most "warning: function declaration isn't a prototype" warnings from Xprint/ --- Xprint/Init.c | 8 +++----- Xprint/attributes.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index cee9e47cf..9fba6c558 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -378,7 +378,7 @@ PrinterOptions( char **argv, int i) { - extern void ddxUseMsg(); + extern void ddxUseMsg(void); if(strcmp(argv[i], "-XpFile") == 0) { if ((i + 1) >= argc) { @@ -693,7 +693,7 @@ StoreDriverNames(void) * from the printerDb is store in the attribute store for the printer. */ static void -StoreDescriptors() +StoreDescriptors(void) { PrinterDbPtr pEntry; @@ -1709,9 +1709,7 @@ GenericScreenInit( * freeing the associated memory. */ static char * -QualifyName(fileName, searchPath) - char *fileName; - char *searchPath; +QualifyName(char *fileName, char *searchPath) { char * curPath = searchPath; char * nextPath; diff --git a/Xprint/attributes.c b/Xprint/attributes.c index 16724e4f8..8e4c811cb 100644 --- a/Xprint/attributes.c +++ b/Xprint/attributes.c @@ -158,7 +158,7 @@ static char NULL_STRING[] = "\0"; * where the print server configuration directory is localed. */ static -char *XpGetConfigDirBase() +char *XpGetConfigDirBase(void) { char *configDir; From ac21e6a594eac69101aa8920d70a9d60412b57f6 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 09:00:42 -0700 Subject: [PATCH 07/16] remove unused variable warning in Xprint/ddxInit.c --- Xprint/ddxInit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/Xprint/ddxInit.c b/Xprint/ddxInit.c index 67035e528..0de38cd2c 100644 --- a/Xprint/ddxInit.c +++ b/Xprint/ddxInit.c @@ -76,8 +76,6 @@ InitOutput( char **argv) { - int i; - pScreenInfo->imageByteOrder = IMAGE_BYTE_ORDER; pScreenInfo->bitmapScanlineUnit = BITMAP_SCANLINE_UNIT; pScreenInfo->bitmapScanlinePad = BITMAP_SCANLINE_PAD; From 60bd8893d50ed1da9b94f4b96a07ea432e23f467 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 09:01:21 -0700 Subject: [PATCH 08/16] Properly #ifdef out ddxBeforeReset() to fix compiler warning --- Xprint/ddxInit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Xprint/ddxInit.c b/Xprint/ddxInit.c index 0de38cd2c..844cba1c2 100644 --- a/Xprint/ddxInit.c +++ b/Xprint/ddxInit.c @@ -237,11 +237,13 @@ OsVendorFatalError(void) } #endif +#ifdef DDXBEFORERESET void ddxBeforeReset(void) { return; } +#endif #ifdef DDXTIME CARD32 From bccde1609153dee93f6fe5a138fc0c0f2fe08212 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 09:01:59 -0700 Subject: [PATCH 09/16] fix incompatible pointer warning in Xprint/ddxInit.c --- Xprint/ddxInit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xprint/ddxInit.c b/Xprint/ddxInit.c index 844cba1c2..29e7c9814 100644 --- a/Xprint/ddxInit.c +++ b/Xprint/ddxInit.c @@ -177,7 +177,7 @@ InitInput( int argc, char **argv) { - DevicePtr ptr, kbd; + DeviceIntPtr ptr, kbd; ptr = AddInputDevice((DeviceProc)PointerProc, TRUE); kbd = AddInputDevice((DeviceProc)KeyboardProc, TRUE); From d90eecf40ea768b2bf6340f15bb0af9dab2f3cf3 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 09:11:41 -0700 Subject: [PATCH 10/16] add some missing function prototypes to Xprint/AttrValid.h to fix compiler warnings --- Xprint/AttrValid.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Xprint/AttrValid.h b/Xprint/AttrValid.h index f2e53f6c5..fab3a7f5e 100644 --- a/Xprint/AttrValid.h +++ b/Xprint/AttrValid.h @@ -196,6 +196,9 @@ void XpPutTrayMediumListAttr(XpContextPtr pContext, XPAttributes pool, XpOid oid, const XpOidTrayMediumList* tm); +void XpValidatePrinterMediaAttrs(XpContextPtr pContext, + const XpOidList* valid_trays, + const XpOidList* valid_sizes); /* * Attribute pool validation */ @@ -204,6 +207,7 @@ void XpValidateAttributePool(XpContextPtr pContext, const XpValidatePoolsRec* vpr); void XpValidatePrinterPool(XpContextPtr pContext, const XpValidatePoolsRec* vpr); +void XpValidateNotificationProfile(XpContextPtr pContext); void XpValidateJobPool(XpContextPtr pContext, const XpValidatePoolsRec* vpr); void XpValidateDocumentPool(XpContextPtr pContext, From 494895e0fbbf0a71bc535c0a2358c9db54c95c5a Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 09:43:44 -0700 Subject: [PATCH 11/16] Properly define dispatchExceptionAtReset to fix compiler warnings --- Xprint/Init.c | 2 -- include/dix.h | 1 + os/utils.c | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index 9fba6c558..50fa4716c 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -300,8 +300,6 @@ static Bool xprintInitGlobalsCalled = FALSE; */ void PrinterInitGlobals(void) { - extern char dispatchExceptionAtReset; /* defined in Xserver/dix/dispatch.c */ - xprintInitGlobalsCalled = TRUE; #ifdef DAMAGE diff --git a/include/dix.h b/include/dix.h index 7a4f49d4a..01777213d 100644 --- a/include/dix.h +++ b/include/dix.h @@ -294,6 +294,7 @@ extern ClientPtr requestingClient; extern ClientPtr *clients; extern ClientPtr serverClient; extern int currentMaxClients; +extern char dispatchExceptionAtReset; typedef int HWEventQueueType; typedef HWEventQueueType* HWEventQueuePtr; diff --git a/os/utils.c b/os/utils.c index bfbc367c5..8655c3e49 100644 --- a/os/utils.c +++ b/os/utils.c @@ -287,8 +287,6 @@ int userdefinedfontpath = 0; char *dev_tty_from_init = NULL; /* since we need to parse it anyway */ -extern char dispatchExceptionAtReset; - /* Extension enable/disable in miinitext.c */ extern Bool EnableDisableExtension(char *name, Bool enable); extern void EnableDisableExtensionError(char *name, Bool enable); From 40fb7eecaf14a76f35ac2dc350ad2fffdaf6e0d0 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 10:11:17 -0700 Subject: [PATCH 12/16] fix noDamageExtension warning in Xprint/Init.c Also took out duplicate definition of this variable in mi/miinitext.c --- Xprint/Init.c | 5 +---- mi/miinitext.c | 4 +--- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index 50fa4716c..1df8998eb 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -308,10 +308,7 @@ void PrinterInitGlobals(void) * https://bugs.freedesktop.org/show_bug.cgi?id=1660) ... * (you can enable the DAMAGE extension explicitly via * % X +extension DAMAGE ... #) ;-( */ - { - extern Bool noDamageExtension; - noDamageExtension = TRUE; - } + noDamageExtension = TRUE; #endif /* DAMAGE */ #ifdef SMART_SCHEDULE diff --git a/mi/miinitext.c b/mi/miinitext.c index 7626c8494..170efed93 100644 --- a/mi/miinitext.c +++ b/mi/miinitext.c @@ -85,6 +85,7 @@ SOFTWARE. #include "misc.h" #include "extension.h" #include "micmap.h" +#include "globals.h" #if defined(QNX4) /* sleaze for Watcom on QNX4 ... */ #undef GLXEXT @@ -125,9 +126,6 @@ extern Bool noBigReqExtension; #ifdef COMPOSITE extern Bool noCompositeExtension; #endif -#ifdef DAMAGE -extern Bool noDamageExtension; -#endif #ifdef DBE extern Bool noDbeExtension; #endif From 9e0c82386ae389bcc296a5ad44e996790b033ad3 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 10:16:37 -0700 Subject: [PATCH 13/16] fix already-defined warning in Xprint/Init.c --- Xprint/Init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index 1df8998eb..efee000ce 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -373,7 +373,6 @@ PrinterOptions( char **argv, int i) { - extern void ddxUseMsg(void); if(strcmp(argv[i], "-XpFile") == 0) { if ((i + 1) >= argc) { From a940b851faba569e36983f7885aefa72f7bf2ade Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 10:17:53 -0700 Subject: [PATCH 14/16] fix function pointer warning in Xprint/Init.c --- Xprint/Init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xprint/Init.c b/Xprint/Init.c index efee000ce..70754e9ca 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -1601,7 +1601,7 @@ InitPrintDrivers( } if(callInit == TRUE) { - Bool (*initFunc)(); + Bool (*initFunc)(BFuncArgs); initFunc = GetInitFunc(pDb->driverName); if(initFunc(index, pScreen, argc, argv) == FALSE) { From c405659626477f2009603d8c0e381b8b62277bb6 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 10:19:24 -0700 Subject: [PATCH 15/16] comment out QualifyName in Xprint/Init.c which is not used anymore If someone else wants to delete this function, that's fine with me too. --- Xprint/Init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Xprint/Init.c b/Xprint/Init.c index 70754e9ca..0f1be6791 100644 --- a/Xprint/Init.c +++ b/Xprint/Init.c @@ -1693,6 +1693,7 @@ GenericScreenInit( (unsigned short)(maxHeight + 0.5); } +#if 0 /* No one uses this anymore... */ /* * QualifyName - takes an unqualified file name such as X6printers and * a colon-separated list of directory path names such as @@ -1741,6 +1742,7 @@ QualifyName(char *fileName, char *searchPath) } return NULL; } +#endif /* * FillPrinterListEntry fills in a single XpDiListEntry element with data From 9fa73721f0c3df73e508da909a5665f47a54cb57 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 8 Jun 2006 10:27:28 -0700 Subject: [PATCH 16/16] fix up EnableDisableExtension() and EnableDisableExtensionError() prototypes --- hw/xfree86/common/xf86Config.c | 4 +--- include/extension.h | 4 ++++ os/utils.c | 5 +---- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 2cb47545b..36dde3031 100644 --- a/hw/xfree86/common/xf86Config.c +++ b/hw/xfree86/common/xf86Config.c @@ -67,6 +67,7 @@ #include "xf86_OSlib.h" #include "globals.h" +#include "extension.h" #ifdef XINPUT #include "xf86Xinput.h" @@ -2524,9 +2525,6 @@ configDRI(XF86ConfDRIPtr drip) } #endif -/* Extension enable/disable in miinitext.c */ -extern Bool EnableDisableExtension(char *name, Bool enable); - static Bool configExtensions(XF86ConfExtensionsPtr conf_ext) { diff --git a/include/extension.h b/include/extension.h index 34750173b..613076dea 100644 --- a/include/extension.h +++ b/include/extension.h @@ -56,6 +56,10 @@ extern unsigned short StandardMinorOpcode(ClientPtr /*client*/); extern unsigned short MinorOpcodeOfRequest(ClientPtr /*client*/); +extern Bool EnableDisableExtension(char *name, Bool enable); + +extern void EnableDisableExtensionError(char *name, Bool enable); + extern void InitExtensions(int argc, char **argv); extern void InitVisualWrap(void); diff --git a/os/utils.c b/os/utils.c index 8655c3e49..43c6365a4 100644 --- a/os/utils.c +++ b/os/utils.c @@ -72,6 +72,7 @@ OR PERFORMANCE OF THIS SOFTWARE. #include "input.h" #include "dixfont.h" #include "osdep.h" +#include "extension.h" #ifdef X_POSIX_C_SOURCE #define _POSIX_C_SOURCE X_POSIX_C_SOURCE #include @@ -287,10 +288,6 @@ int userdefinedfontpath = 0; char *dev_tty_from_init = NULL; /* since we need to parse it anyway */ -/* Extension enable/disable in miinitext.c */ -extern Bool EnableDisableExtension(char *name, Bool enable); -extern void EnableDisableExtensionError(char *name, Bool enable); - OsSigHandlerPtr OsSignal(sig, handler) int sig;