frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Xi: xibarriers: protect add_master_func() from allocation failure 

Try to gracefully handle OOM situation, at not hard crashing.

| ../Xi/xibarriers.c: In function ‘add_master_func’:
| ../Xi/xibarriers.c:729:19: warning: dereference of NULL ‘pbd’ [CWE-476] [-Wanalyzer-null-dereference]
|  729 |     pbd->deviceid = *deviceid;
|       |     ~~~~~~~~~~~~~~^~~~~~~~~~~

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2025-05-06 17:13:55 +02:00
parent d91121e876
commit cb69b80973
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Xi/xibarriers.c
View File

@ -722,14 +722,14 @@ static void add_master_func(void *res, XID id, void *devid)
{ {
struct PointerBarrier *b; struct PointerBarrier *b;
struct PointerBarrierClient *barrier; struct PointerBarrierClient *barrier;
struct PointerBarrierDevice *pbd;
int *deviceid = devid; int *deviceid = devid;
b = res; b = res;
barrier = container_of(b, struct PointerBarrierClient, barrier); barrier = container_of(b, struct PointerBarrierClient, barrier);
struct PointerBarrierDevice *pbd = AllocBarrierDevice();
pbd = AllocBarrierDevice(); if (!pbd)
return;
pbd->deviceid = *deviceid; pbd->deviceid = *deviceid;
input_lock(); input_lock();