From ce24f3aa5815e03c2d501d1504f6c0162b219801 Mon Sep 17 00:00:00 2001 From: Alex Goins Date: Thu, 7 Jul 2016 14:50:03 -0700 Subject: [PATCH] modesetting: NULL assignment for drmmode_set_target_scanout_target_cpu Commit 80e64dae: "modesetting: Implement PRIME syncing as a sink" originally was supposed to have this line, but it was dropped as part of the merge process. Foregoing the NULL assignment causes a ton of problems with dereferencing uninitialized memory. Signed-off-by: Alex Goins Reviewed-by: Dave Airlie --- hw/xfree86/drivers/modesetting/drmmode_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_display.c index 4a3fdc56d..2cdcad1fa 100644 --- a/hw/xfree86/drivers/modesetting/drmmode_display.c +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c @@ -956,6 +956,7 @@ drmmode_set_target_scanout_pixmap_cpu(xf86CrtcPtr crtc, PixmapPtr ppix, DamageUnregister(ppriv->slave_damage); ppriv->slave_damage = NULL; } + *target = NULL; } if (!ppix)