frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

XKB: Actually explain keymap failures 

When something went wrong building a keymap, try to explain to the user
what it actually was, instead of the dreaded 'Failed to load XKB keymap'
catch-all.
This commit is contained in:
Daniel Stone 2008-05-07 22:24:19 +03:00
parent 641a5f955b
commit cf20df39cc
1 changed files with 32 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
xkb/ddxLoad.c
View File

@ -274,7 +274,7 @@ char tmpname[PATH_MAX];
return True; return True;
} }
else else
DebugF("Error compiling keymap (%s)\n",keymap); LogMessage(X_ERROR, "Error compiling keymap (%s)\n", keymap);
#ifdef WIN32 #ifdef WIN32
/* remove the temporary file */ /* remove the temporary file */
unlink(tmpname); unlink(tmpname);
@ -282,9 +282,9 @@ char tmpname[PATH_MAX];
} }
else { else {
#ifndef WIN32 #ifndef WIN32
DebugF("Could not invoke keymap compiler\n"); LogMessage(X_ERROR, "XKB: Could not invoke xkbcomp\n");
#else #else
DebugF("Could not open file %s\n", tmpname); LogMessage(X_ERROR, "Could not open file %s\n", tmpname);
#endif #endif
} }
if (nameRtrn) if (nameRtrn)
@ -350,11 +350,13 @@ unsigned missing;
if ((names->keycodes==NULL)&&(names->types==NULL)&& if ((names->keycodes==NULL)&&(names->types==NULL)&&
(names->compat==NULL)&&(names->symbols==NULL)&& (names->compat==NULL)&&(names->symbols==NULL)&&
(names->geometry==NULL)) { (names->geometry==NULL)) {
LogMessage(X_ERROR, "XKB: No components provided for device %s\n",
keybd->name);
return 0; return 0;
} }
else if (!XkbDDXCompileKeymapByNames(xkb,names,want,need, else if (!XkbDDXCompileKeymapByNames(xkb,names,want,need,
nameRtrn,nameRtrnLen)){ nameRtrn,nameRtrnLen)){
DebugF("Couldn't compile keymap file\n"); LogMessage(X_ERROR, "XKB: Couldn't compile keymap\n");
return 0; return 0;
} }
file= XkbDDXOpenConfigFile(nameRtrn,fileName,PATH_MAX); file= XkbDDXOpenConfigFile(nameRtrn,fileName,PATH_MAX);
@ -369,7 +371,7 @@ unsigned missing;
(void) unlink (fileName); (void) unlink (fileName);
return 0; return 0;
} }
else if (xkbDebugFlags) { else {
DebugF("Loaded XKB keymap %s, defined=0x%x\n",fileName,(*xkbRtrn)->defined); DebugF("Loaded XKB keymap %s, defined=0x%x\n",fileName,(*xkbRtrn)->defined);
} }
fclose(file); fclose(file);
@ -390,32 +392,40 @@ XkbRF_RulesPtr rules;
if (!rules_name) if (!rules_name)
return False; return False;
if (XkbBaseDirectory==NULL) {
if (strlen(rules_name)+7 > PATH_MAX) if (strlen(XkbBaseDirectory) + strlen(rules_name) + 8 > PATH_MAX) {
return False; LogMessage(X_ERROR, "XKB: Rules name is too long\n");
sprintf(buf,"rules/%s",rules_name); return False;
} }
else { sprintf(buf,"%s/rules/%s", XkbBaseDirectory, rules_name);
if (strlen(XkbBaseDirectory)+strlen(rules_name)+8 > PATH_MAX)
return False; file = fopen(buf, "r");
sprintf(buf,"%s/rules/%s",XkbBaseDirectory,rules_name); if (!file) {
} LogMessage(X_ERROR, "XKB: Couldn't open rules file %s\n", file);
if ((file= fopen(buf,"r"))==NULL)
return False; return False;
if ((rules= XkbRF_Create(0,0))==NULL) { }
rules = XkbRF_Create(0, 0);
if (!rules) {
LogMessage(X_ERROR, "XKB: Couldn't create rules struct\n");
fclose(file); fclose(file);
return False; return False;
} }
if (!XkbRF_LoadRules(file,rules)) {
if (!XkbRF_LoadRules(file, rules)) {
LogMessage(X_ERROR, "XKB: Couldn't parse rules file %s\n", rules_name);
fclose(file); fclose(file);
XkbRF_Free(rules,True); XkbRF_Free(rules,True);
return False; return False;
} }
bzero((char *)names,sizeof(XkbComponentNamesRec));
complete= XkbRF_GetComponents(rules,defs,names); memset(names, 0, sizeof(*names));
complete = XkbRF_GetComponents(rules,defs,names);
fclose(file); fclose(file);
XkbRF_Free(rules,True); XkbRF_Free(rules, True);
if (!complete)
LogMessage(X_ERROR, "XKB: Rules returned no components\n");
return complete; return complete;
} }