From d13cd3862e9ccd35c91a06680d02f2fc8fd03420 Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Thu, 5 Apr 2018 12:48:26 -0400 Subject: [PATCH] dmx: Silence a string truncation warning. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ../hw/dmx/config/dmxparse.c: In function ‘dmxConfigCreateOption’: ../hw/dmx/config/dmxparse.c:385:13: warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(option->string + offset, p->string, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../hw/dmx/config/dmxparse.c:383:23: note: length computed here int len = strlen(p->string); ^~~~~~~~~~~~~~~~~ The thing it's warning about is intentional, the surrounding code does its own nul-termination. Make that obvious by using memcpy instead. Signed-off-by: Adam Jackson Acked-by: Keith Packard --- hw/dmx/config/dmxparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dmx/config/dmxparse.c b/hw/dmx/config/dmxparse.c index cf510844d..f66143a6a 100644 --- a/hw/dmx/config/dmxparse.c +++ b/hw/dmx/config/dmxparse.c @@ -382,7 +382,7 @@ dmxConfigCreateOption(DMXConfigTokenPtr pStart, if (p->string) { int len = strlen(p->string); - strncpy(option->string + offset, p->string, len); + memcpy(option->string + offset, p->string, len); offset += len; if (p->next) option->string[offset++] = ' ';