From d3d845ca9e92f0a2ccde93f4242d7769cfe14164 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michel=20D=C3=A4nzer?= Date: Thu, 25 Sep 2014 15:27:22 +0900 Subject: [PATCH] glamor: Use GL_STREAM_READ also for read/write access to a PBO MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otherwise the CPU may end up reading from non-cacheable memory, which is very slow. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84178 Signed-off-by: Michel Dänzer Reviewed-by: Markus Wick Reviewed-by: Eric Anholt Signed-off-by: Keith Packard --- glamor/glamor_prepare.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/glamor/glamor_prepare.c b/glamor/glamor_prepare.c index 561c55d19..fb85d9082 100644 --- a/glamor/glamor_prepare.c +++ b/glamor/glamor_prepare.c @@ -84,10 +84,7 @@ glamor_prep_pixmap_box(PixmapPtr pixmap, glamor_access_t access, BoxPtr box) if (priv->base.pbo == 0) glGenBuffers(1, &priv->base.pbo); - if (access == GLAMOR_ACCESS_RW) - gl_usage = GL_DYNAMIC_DRAW; - else - gl_usage = GL_STREAM_READ; + gl_usage = GL_STREAM_READ; glBindBuffer(GL_PIXEL_PACK_BUFFER, priv->base.pbo); glBufferData(GL_PIXEL_PACK_BUFFER,