frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

os: prevent negative array index access (#80890) 

If an empty string is provided to LogMessageVerbSigSafe, the length of the
printed string is 0.

Read-only access only and the only effect it had was adding a linebreak or not.

X.Org Bug 80890 <http://bugs.freedesktop.org/show_bug.cgi?id=80890>

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer 2014-07-07 08:27:44 +10:00
parent 9de3cc8daa
commit daa1a9d22d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os/log.c
View File

@ -697,7 +697,7 @@ LogVMessageVerbSigSafe(MessageType type, int verb, const char *format, va_list a
if (sizeof(buf) - len == 1) if (sizeof(buf) - len == 1)
buf[len - 1] = '\n'; buf[len - 1] = '\n';
newline = (buf[len - 1] == '\n'); newline = (len > 0 && buf[len - 1] == '\n');
LogSWrite(verb, buf, len, newline); LogSWrite(verb, buf, len, newline);
} }