frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xres/xkb/xvmc/modesetting: Fix incorrect pointer data size usage 

* xled change tested with `xset led named "Scroll Lock"`
* modesetting change tested with `xrandr --output DP-1 --gamma 0.5:0.5:0.5`.
  Without this fix that command does nothing
* xvmc change tested with `mpv --vo=xv video.mp4`

Of the currently reported issues this fixes #104

Signed-off-by: dec05eba <dec05eba@protonmail.com>
This commit is contained in:
dec05eba 2025-06-12 23:31:20 +02:00 committed by Enrico Weigelt
parent fea8b78358
commit f397039d65
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Xext/xres.c
View File

@ -341,7 +341,7 @@ ProcXResQueryClientResources(ClientPtr client)
free(counts);
WriteToClient(client, sizeof(xXResQueryClientResourcesReply), &rep);
WriteToClient(client, sizeof(scratch), scratch);
WriteToClient(client, num_types * sizeof(xXResType), scratch);
free(scratch);
return Success;
}

2
Xext/xvmc.c
View File

@ -594,7 +594,7 @@ ProcXvMCListSubpictureTypes(ClientPtr client)
.type = X_Reply,
.sequenceNumber = client->sequence,
.num = num,
.length = bytes_to_int32(sizeof(info)),
.length = bytes_to_int32(num * sizeof(xvImageFormatInfo)),
};
WriteToClient(client, sizeof(xvmcListSubpictureTypesReply), &rep);

2
hw/xfree86/drivers/modesetting/drmmode_display.c
View File

@ -1927,7 +1927,7 @@ drmmode_set_gamma_lut(drmmode_crtc_private_ptr drmmode_crtc,
}
uint32_t blob_id;
if (drmModeCreatePropertyBlob(drmmode->fd, lut, sizeof(lut), &blob_id)) {
if (drmModeCreatePropertyBlob(drmmode->fd, lut, size * sizeof(struct drm_color_lut), &blob_id)) {
free(lut);
return;
}

2
xkb/xkbLEDs.c
View File

@ -806,7 +806,7 @@ XkbFlushLedEvents(DeviceIntPtr dev,
XkbDDXUpdateDeviceIndicators(dev, sli, sli->effectiveState);
XkbSendExtensionDeviceNotify(dev, cause->client, ed);
}
memset((char *) ed, 0, sizeof(XkbExtensionDeviceNotify));
memset((char *) ed, 0, sizeof(xkbExtensionDeviceNotify));
}
return;
}