frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(submit/os-utils) os: utils: drop obsolete REMOVE_ENV_LD conditional 

This always had been set since it's incarnation back two decades
ago, on XFree86 4.3.0.1. Probably no need to keep that around anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult 2024-05-03 17:58:11 +02:00
parent 97a84d7e18
commit f50d7d72ad
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
os/utils.c
View File

@ -1358,11 +1358,6 @@ PrivsElevated(void)
* external wrapper utility. * external wrapper utility.
*/ */
/* Consider LD* variables insecure? */
#ifndef REMOVE_ENV_LD
#define REMOVE_ENV_LD 1
#endif
/* Check args and env only if running setuid (euid == 0 && euid != uid) ? */ /* Check args and env only if running setuid (euid == 0 && euid != uid) ? */
#ifndef CHECK_EUID #ifndef CHECK_EUID
#ifndef WIN32 #ifndef WIN32
@ -1432,13 +1427,11 @@ CheckUserParameters(int argc, char **argv, char **envp)
for (i = 0; envp[i]; i++) { for (i = 0; envp[i]; i++) {
/* Check for bad environment variables and values */ /* Check for bad environment variables and values */
#if REMOVE_ENV_LD
while (envp[i] && (strncmp(envp[i], "LD", 2) == 0)) { while (envp[i] && (strncmp(envp[i], "LD", 2) == 0)) {
for (j = i; envp[j]; j++) { for (j = i; envp[j]; j++) {
envp[j] = envp[j + 1]; envp[j] = envp[j + 1];
} }
} }
#endif
if (envp[i] && (strlen(envp[i]) > MAX_ENV_LENGTH)) { if (envp[i] && (strlen(envp[i]) > MAX_ENV_LENGTH)) {
for (j = i; envp[j]; j++) { for (j = i; envp[j]; j++) {
envp[j] = envp[j + 1]; envp[j] = envp[j + 1];