frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

os: log: drop unused variables 

Drop some unneeded variabes, whose values can be computed at compile-time.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
This commit is contained in:
Enrico Weigelt, metux IT consult 2024-09-12 14:06:22 +02:00 committed by Marge Bot
parent a33639f975
commit f5fe8a6379
1 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
os/log.c
View File

@ -670,8 +670,6 @@ LogVMessageVerb(MessageType type, int verb, const char *format, va_list args)
{ {
const char *type_str; const char *type_str;
char buf[1024]; char buf[1024];
const size_t size = sizeof(buf);
Bool newline;
size_t len = 0; size_t len = 0;
if (inSignalContext) { if (inSignalContext) {
@ -685,17 +683,16 @@ LogVMessageVerb(MessageType type, int verb, const char *format, va_list args)
/* if type_str is not "", prepend it and ' ', to message */ /* if type_str is not "", prepend it and ' ', to message */
if (type_str[0] != '\0') if (type_str[0] != '\0')
len += Xscnprintf(&buf[len], size - len, "%s ", type_str); len += Xscnprintf(&buf[len], sizeof(buf) - len, "%s ", type_str);
if (size - len > 1) if (sizeof(buf) - len > 1)
len += Xvscnprintf(&buf[len], size - len, format, args); len += Xvscnprintf(&buf[len], sizeof(buf) - len, format, args);
/* Force '\n' at end of truncated line */ /* Force '\n' at end of truncated line */
if (size - len == 1) if (sizeof(buf) - len == 1)
buf[len - 1] = '\n'; buf[len - 1] = '\n';
newline = (buf[len - 1] == '\n'); LogSWrite(verb, buf, len, (buf[len - 1] == '\n'));
LogSWrite(verb, buf, len, newline);
} }
/* Log message with verbosity level specified. */ /* Log message with verbosity level specified. */
@ -736,7 +733,6 @@ LogVMessageVerbSigSafe(MessageType type, int verb, const char *format, va_list a
const char *type_str; const char *type_str;
char buf[1024]; char buf[1024];
int len; int len;
Bool newline;
type_str = LogMessageTypeVerbString(type, verb); type_str = LogMessageTypeVerbString(type, verb);
if (!type_str) if (!type_str)
@ -754,8 +750,7 @@ LogVMessageVerbSigSafe(MessageType type, int verb, const char *format, va_list a
if (sizeof(buf) - len == 1) if (sizeof(buf) - len == 1)
buf[len - 1] = '\n'; buf[len - 1] = '\n';
newline = (len > 0 && buf[len - 1] == '\n'); LogSWrite(verb, buf, len, (len > 0 && buf[len - 1] == '\n'));
LogSWrite(verb, buf, len, newline);
} }
void void
@ -764,8 +759,6 @@ LogVHdrMessageVerb(MessageType type, int verb, const char *msg_format,
{ {
const char *type_str; const char *type_str;
char buf[1024]; char buf[1024];
const size_t size = sizeof(buf);
Bool newline;
size_t len = 0; size_t len = 0;
int (*vprintf_func)(char *, int, const char* _X_RESTRICT_KYWD f, va_list args) int (*vprintf_func)(char *, int, const char* _X_RESTRICT_KYWD f, va_list args)
_X_ATTRIBUTE_PRINTF(3, 0); _X_ATTRIBUTE_PRINTF(3, 0);
@ -786,20 +779,19 @@ LogVHdrMessageVerb(MessageType type, int verb, const char *msg_format,
/* if type_str is not "", prepend it and ' ', to message */ /* if type_str is not "", prepend it and ' ', to message */
if (type_str[0] != '\0') if (type_str[0] != '\0')
len += printf_func(&buf[len], size - len, "%s ", type_str); len += printf_func(&buf[len], sizeof(buf) - len, "%s ", type_str);
if (hdr_format && size - len > 1) if (hdr_format && sizeof(buf) - len > 1)
len += vprintf_func(&buf[len], size - len, hdr_format, hdr_args); len += vprintf_func(&buf[len], sizeof(buf) - len, hdr_format, hdr_args);
if (msg_format && size - len > 1) if (msg_format && sizeof(buf) - len > 1)
len += vprintf_func(&buf[len], size - len, msg_format, msg_args); len += vprintf_func(&buf[len], sizeof(buf) - len, msg_format, msg_args);
/* Force '\n' at end of truncated line */ /* Force '\n' at end of truncated line */
if (size - len == 1) if (sizeof(buf) - len == 1)
buf[len - 1] = '\n'; buf[len - 1] = '\n';
newline = (buf[len - 1] == '\n'); LogSWrite(verb, buf, len, (buf[len - 1] == '\n'));
LogSWrite(verb, buf, len, newline);
} }
void void