frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dix/window: Use ConfigureWindow instead of MoveWindow 

The screensaver can regularly move its window to random offsets. It should
use the ConfigureWindow function instead of calling the Screen's MoveWindow
directly. Some MoveWindow implementations, such as compMoveWindow, rely on
Screen's ConfigNotify being called first as it happens in ConfigureWindow.

Reviewed-by: Adam Jackson <ajax@redhat.com>
This commit is contained in:
Michal Srb 2018-11-12 13:51:48 +01:00 committed by Adam Jackson
parent 23752b3ef8
commit fbdd4d679a
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dix/window.c
View File

@ -3094,6 +3094,7 @@ int
dixSaveScreens(ClientPtr client, int on, int mode)
{
int rc, i, what, type;
XID vlist[2];
if (on == SCREEN_SAVER_FORCER) {
if (mode == ScreenSaverReset)
@ -3146,14 +3147,11 @@ dixSaveScreens(ClientPtr client, int on, int mode)
* for the root window, so PaintWindow works
*/
screenIsSaved = SCREEN_SAVER_OFF;
(*pWin->drawable.pScreen->MoveWindow) (pWin,
(short) (-
(rand() %
RANDOM_WIDTH)),
(short) (-
(rand() %
RANDOM_WIDTH)),
pWin->nextSib, VTMove);
vlist[0] = -(rand() % RANDOM_WIDTH);
vlist[1] = -(rand() % RANDOM_WIDTH);
ConfigureWindow(pWin, CWX | CWY, vlist, client);
screenIsSaved = SCREEN_SAVER_ON;
}
/*