From fdc451588816c4bc798d54e56316530e9066be80 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 29 Jan 2013 11:01:29 +1000 Subject: [PATCH] Xi: limit valuator copy to valuator array size (#59939) mask[(MAX_VALUATORS + 7)/8] is larger than data[MAX_VALUATORS], so static code checkers think we may be running OOB on the data array. Mask is initialized to 0, so this should not happen, but change it anyway to shut up code analyzer noise. X.Org Bug 59939 Signed-off-by: Peter Hutterer Reviewed-by: Alan Coopersmith --- Xi/exevents.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index 74f3610cc..609b1268f 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -1263,7 +1263,7 @@ TouchCopyValuatorData(DeviceEvent *ev, TouchPointInfoPtr ti) { int i; - for (i = 0; i < sizeof(ev->valuators.mask) * 8; i++) + for (i = 0; i < ARRAY_SIZE(ev->valuators.data); i++) if (BitIsOn(ev->valuators.mask, i)) valuator_mask_set_double(ti->valuators, i, ev->valuators.data[i]); }