Enrico Weigelt, metux IT consult
6964009a16
( !1969 ) xfree86: int10: extra NULL protection
...
Even though chances are really low it's ever getting hit, it's still safer
to have some sanity checks (which don't cost us much) than risking segfault.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:40 +02:00
Enrico Weigelt, metux IT consult
1993c1f7c6
( !1969 ) xfree86: modes: fix uninitialized variables
...
| ../hw/xfree86/modes/xf86RandR12.c: In function ‘xf86ComputeCrtcPan’:
| ../hw/xfree86/modes/xf86RandR12.c:310:54: warning: use of uninitialized value ‘r[1]’ [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
| 310 | q[i] = m->m[1][i] * r[0] - m->m[0][i] * r[1];
| | ~^~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:40 +02:00
Enrico Weigelt, metux IT consult
25fac50dcc
( !1969 ) xfree86: loader: add assert() in LoadModule()
...
There's (remote) chance that the (internal) module name could become
NULL (eg. allocation failure). Even though chances to hit it are very
low, it's still better to have a check here (that doesn't cost us much),
just in case. Assert fail is still better than segfault, since we're
at least getting some hint what might have happened.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:40 +02:00
Enrico Weigelt, metux IT consult
361f78bf4c
( !1969 ) xfree86: parser: check for alloc failure and possible NULL pointers
...
Adding paranoid extra checks against allocation failure and NULL pointers.
Even though might not be actually hit in practise, it's still better to
be cautious, just in case. And reducing analyzer noise this way.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:40 +02:00
Enrico Weigelt, metux IT consult
8fd16682e1
( !1969 ) xfree86: x86emu: add extra assert()'s
...
The analyzer warnings (possible NULL dereference) are probably just
false alarms. But for safety adding assert()'s, which don't cost us
anything in non-debug builds.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:40 +02:00
Enrico Weigelt, metux IT consult
97a5423197
( !1974 ) os: drop self-limiting resources
...
It's only rarely used and can be easily achieved by generic means,
eg. via ulimit or supervisor settings.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:39 +02:00
Enrico Weigelt, metux IT consult
b5c1771945
( !1982 ) include: don't install propertyst.h
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:39 +02:00
Enrico Weigelt, metux IT consult
e3fb6235c2
( !1982 ) xfree86: xf86Priv.h: dont include propertyst.h
...
Nothing in here needs anything from that include file, so no need for
including it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:39 +02:00
Enrico Weigelt, metux IT consult
1f5a65cbb6
( !1982 ) xfree86: xf86.h: dont include propertyst.h
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:39 +02:00
Enrico Weigelt, metux IT consult
aa6614babf
( !1982 ) xfree86: xf86Events.c: add missing include of property.h
...
the file calls some functions from property.h, so it needs to be included.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:39 +02:00
Enrico Weigelt, metux IT consult
1fdd80ad6f
( !1985 ) randr: unexport and document RRProviderAutoConfigGpuScreen()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:38 +02:00
Enrico Weigelt, metux IT consult
447c9557e9
( !1985 ) randr: unexport and document RROutputSetSubpixelOrder()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:38 +02:00
Enrico Weigelt, metux IT consult
0f721f8878
( !1985 ) randr: unexport and document RRHasScanoutPixmap()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:37 +02:00
Enrico Weigelt, metux IT consult
9c4c30e9dc
( !1985 ) randr: unexport and document RRCrtcDetachScanoutPixmap()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:37 +02:00
Enrico Weigelt, metux IT consult
ed9c55c3d7
( !1985 ) randr: unexport and document RRCrtcDestroy()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:37 +02:00
Enrico Weigelt, metux IT consult
5497972937
( !1985 ) randr: unexport and document RRResourcesChanged()
...
Not used by external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:37 +02:00
Enrico Weigelt, metux IT consult
1d2ce6eefa
( !1987 ) glamor: unexport glamor_set_glvnd_vendor()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:36 +02:00
Enrico Weigelt, metux IT consult
f9668b2a4e
( !1987 ) glamor: unexport glamor_set_pixmap_texture()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:36 +02:00
Enrico Weigelt, metux IT consult
56d69a7f88
( !1987 ) ephyr: workaround for name clash between Xlib and Xserver
...
A slight change in include order can cause Xlib to be included and defining
"GC" type, which is conflicting with Xserver's own type by same name.
As long as MR !1393 hasn't merged yet, we need to do an ugly workaround
using some preprocessor black magic.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
c7db35ddfe
( !1988 ) xfree86: drop xf86VGAarbiter.h
...
It doesn't serve any practical purpose anymore and also isn't included
by any external driver, thus also no need to keep it in SDK.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
65d066752d
( !1988 ) xfree86: unexport xf86VGAarbiterAllowDRI()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
cd65f1782e
( !1988 ) xfree86: drop obsolete xf86VGAarbiterDeviceDecodes()
...
Not used by anybody, so no need to keep it anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
5637e3e4fc
( !1979 ) xwayland: protect against alloc failures and NULL pointers
...
Protecting against NULL pointers and allocation failures.
Printing out a bug warning in those cases.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
1ecf9747a0
( !1990 ) xfree86: unexport xf86RemoveInputEventDrainCallback()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
59c5b52fa7
( !1990 ) xfree86: unexport xf86AddInputEventDrainCallback()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
35b8f8f850
( !1990 ) xfree86: unexport xf86LookupInput()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
b06e3af673
( !1990 ) xfree86: unexport xf86LookupInputDriver()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
e0b0c76d24
( !1990 ) xfree86: unexport xf86InputEnableVTProbe()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
f228a227c7
( !1990 ) xfree86: unexport xf86PostButtonEventM()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
a361865a6d
( !1990 ) xfree86: make xf86VIDrvMsgVerb() static
...
Only used inside xf86Helper.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
75678dca4f
( !1990 ) xfree86: make xf86PostKeyEvent() static
...
Only used inside xf86Xinput.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
c469091176
( !1990 ) xfree86: drop obsolete xf86PostKeyEventM()
...
It's now only a wrapper calling xf86PostKeyEvent(), and no external driver
using it anymore, so we can drop it entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
9c26407716
( !1990 ) xfree86: drop unused xf86DeleteInputDriver()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
d8e0d603dd
( !1990 ) xfree86: drop unused xf86EnableDevice()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
4b8ce1a231
( !1990 ) xfree86: drop unused xf86PostKeyEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
160c069116
( !1990 ) xfree86: drop unused xf86PostProximityEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
1b2128f5a1
( !1990 ) xfree86: drop unused xf86PostMotionEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
2d9bd108e6
( !1991 ) xfree86: xf86Option: unexport xf86MarkOptionUsedByName()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
c885613d3b
( !1991 ) xfree86: xf86Option: unexport xf86MarkOptionUsed()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
99f022731f
( !1991 ) xfree86: xf86Option: unexport xf86OptionListReport()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
4e1885f3d5
( !1991 ) xfree86: xf86Option: make xf86CheckIfOptionUsedByName() static
...
Only used inside of xf86Option.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
529deae922
( !1991 ) xfree86: xf86Option: drop unused xf86CheckIfOptionUsed()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
b697b2bc51
( !1991 ) xfree86: xf86Option: drop unused xf86ReplacePercentOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
6696742112
( !1991 ) xfree86: xf86Option: drop unused xf86ReplaceRealOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
fcd70be3ed
( !1991 ) xfree86: xf86Option: drop unused xf86GetOptValReal()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
3db4b3ddde
( !1991 ) xfree86: xf86Option: drop unused xf86NewOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
8d87849774
( !1991 ) xfree86: xf86Option: drop unused xf86CheckRealOption()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5e5bc4edf9
( !1992 ) xfree86: i2c: drop unused xf86I2CWriteWord()
...
Not used anywhere, so no need to keep around it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
7e6b7b03a5
( !1992 ) xfree86: i2c: drop unused xf86I2CWriteBytes()
...
Not used anywhere, so no need to keep around it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
aadaaa2161
( !1992 ) xfree86: i2c: drop unused xf86I2CReadWord()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
f6aed15f68
( !1992 ) xfree86: i2c: drop unused xf86I2CReadStatus()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
9747f56329
( !1993 ) xfree86: vbe: drop dead code
...
This never seemed to be actually enabled, just ifdef'ed out, so no
need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
bec4f5a510
( !1993 ) xfree86: vbe: drop unused VBEGetVBEpmi()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
b168365763
( !1993 ) xfree86: vbe: drop unused VBEGetDisplayStart()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
ed56bb9752
( !1994 ) xfree86: ddc: make DMTModes[] static
...
Only used inside xf86EdidModes.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
83301fa98f
( !1994 ) xfree86: ddc: make FindDMTMode() static
...
Only used inside xf86EdidModes.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
e15cb124fd
( !1994 ) xfree86: ddc: unexport gtf_supported()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
3a0fa92f4e
( !1994 ) xfree86: ddc: drop unused xf86MonitorIsHDMI()
...
Not used anywhere, so no need to keep it anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
893409e09d
( !1994 ) xfree86: ddc: unexport xf86EdidMonitorSet()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
9fd2de407d
( !1995 ) xfree86: xisb: drop unused XisbTrace()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
1c3e21694a
( !1995 ) xfree86: xisb: drop unused XisbWrite()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
85914d59ba
( !1996 ) xfree86: xv: unexport XF86XvScreenKey
...
Not used by any drivers, and the include is private anyways.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
22904a4c43
( !1996 ) xfree86: xv: don't install xf86xvpriv.h
...
Not included by any drivers, and it's supposed to be private anyways.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
3d04c302a9
( !1996 ) xfree86: xv: drop unused xf86XVFillKeyHelperPort()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
b7b7ed9f13
( !1997 ) xfree86: fbman: move FBManagerFuncs into x86fbman.c
...
Only used here, so no need to keep it in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
458bfb9b3c
( !1997 ) xfree86: fbman: make xf86InitFBManagerRegion() static
...
Only called locally within xf86fbman.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
d276caae83
( !1997 ) xfree86: fbman: make xf86RegisterOffscreenManager()
...
Only called locally within xf86fbman.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5104bae723
( !1997 ) xfree86: fbman: drop FreeBoxesUpdateCallback
...
Nobody fills it anymore, so not needed at all anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5da301d8a4
( !1997 ) xfree86: fbman: drop RegisterFreeBoxCallback proc pointer
...
Nobody calls it anymore, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
6b8b67aba0
( !1997 ) xfree86: fbman: drop unused xf86RegisterFreeBoxCallback()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
928e5bea2b
( !1997 ) xfree86: fbman: drop unused xf86AllocateLinearOffscreenArea()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
7f9f9e8e73
( !1997 ) xfree86: fbman: drop unused xf86FBManagerRunning()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
e66697088f
( !1997 ) xfree86: fbman: drop unused xf86InitFBManagerArea()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
26e67421cc
( !1988 ) xfree86: loader: drop unused MODULETEARDOWNPROTO() macro
...
Not used anywhere, so no need to keep it in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5f87a8a290
( !1998 ) xfree86: loader: drop unused GET_MODULE_*_VERSION macros
...
Not used anywhere, so no need to keep them around in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
d6e1efa3c1
( !2000 ) xfree86: drop ifdefs on _NO_XF86_PROTOTYPES
...
Nothing ever sets this symbol, so can be dropped.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Olivier Fourdan
b97b459c06
xwayland: Update sprite prior to clearing the focus window
...
Xwayland has its own XYToWindow() handler to account for the case when
the pointer leaves an X11 surface to enter another Wayland native window
(which of course are unknown to Xwayland).
When that occurs, Xwayland will treat it as if the pointer had entered
the root window so that the X11 clients receive an appropriate leave
event.
When the pointer leaves the X11 surface, Xwayland will call
CheckMotion() to update the sprite coordinates and possibly the cursor.
However, CheckMotion() will call back into the XYToWindow() handler,
which will then pretend the window has entered the root window, and that
may cause the wrong cursor to be applied.
To avoid the issue, change the order we do things, by calling
CheckMotion() first prior to clear up the internal focus window so that
the first call to XYToWindow() will return the correct X11 window so we
get to update the cursor correctly.
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1811
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1915 >
2025-05-16 10:02:53 +00:00
Alan Coopersmith
062c339519
modesetting: fix typo in XF86ModuleVersionInfo initialization
...
Found by clang 19.1.7:
hw/xfree86/drivers/modesetting/driver.c:163:21:
warning: initializer overrides prior initialization of this subobject
[-Winitializer-overrides]
163 | ._modinfo1_ = MODINFOSTRING2,
| ^~~~~~~~~~~~~~
hw/xfree86/drivers/modesetting/driver.c:162:21:
note: previous initialization is here
162 | ._modinfo1_ = MODINFOSTRING1,
| ^~~~~~~~~~~~~~
Fixes: 2a10eff6c ("xfree86: modsetting: use explicit field initializers for XF86ModuleData")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:15 +00:00
Alan Coopersmith
f9d25189fa
xfree86: make modeline2c.awk put a newline at the end of xf86DefModeSet.c
...
Clears warning from clang 19.1.7:
hw/xfree86/common/xf86DefModeSet.c:288:62:
warning: no newline at end of file [-Wnewline-eof]
288 | const int xf86NumDefaultModes = ARRAY_SIZE(xf86DefaultModes);
| ^
Fixes: 3bf7ff703 ("Size xf86DefaultModes explicitly.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:15 +00:00
Enrico Weigelt, metux IT consult
c445167da6
xwayland: no need to use WriteReplyToClient()
...
The WriteReplyToClient() macro is used for cases where byte swapping
is implemented in a separate callback function (set in a global vector
table). Since Xwl extension doesn't have such a callback, but does the
byte swapping directly in it's request handlers, there's no need to
call the WriteReplyToClient() macro - we can use WriteToClient() instead.
Fixes: 2700bc6045 - xwayland: add support for the XWAYLAND extension
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1878 >
2025-04-07 07:47:30 +00:00
Enrico Weigelt, metux IT consult
32b3328e49
kdrive: Xkdrive.man: remove stray whitespace
...
Tiny editorial correction: drop a stray whitespace in manpage
that sneaked in at recent editorial changes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1876 >
2025-04-02 00:54:31 +00:00
Alan Coopersmith
5ac0a19e7f
man pages: use .BR to mark up man page references
...
The name of a man page is typeset in bold and the section in roman
(see man-pages(7)).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 13:36:54 -07:00
Bjarni Ingi Gislason
bcf743f356
inputtestdrv.4: editorial changes for this man page
...
Use the correct macro for the font change of a single argument or
split the argument into two.
43:.BI Keyboard
46:.BI Pointer
52:.BI PointerAbsolute
58:.BI PointerAbsoluteProximity
62:.BI Touch
103:.BI xf86ITEventWaitForSync
-.-.
Wrong distance between sentences in the input file.
Separate the sentences and subordinate clauses; each begins on a new
line. See man-pages(7) ("Conventions for source file layout") and
"info groff" ("Input Conventions").
19:server as input events. It supports the full set of the xf86 driver APIs
20:exposed by Xorg. The primary use cases of this input driver are various
29:is created after the driver is initialized. The paths to the socket is passed
37:Sets the path where the driver will create a named socket. Any existing file
47:Initializes a relative-mode pointer device. It will have four valuators -
53:Initializes an absolute-mode pointer device. It will have four valuators -
87:specifies the protocol version supported by it. If this version is lower than
91:to the driver. Each event is an instance of one of the
93:structs. The length field defines the full length of the struct in bytes and
96:The responses from the server follow the same structure. Each response is an
99:structs. The length field defines the full length of the struct in bytes and
104:event. After sending such event, the client must read of a
106:events. The completion of the read operation indicates that Xorg has fully
-.-.
The name of a man page is typeset in bold and the section in roman
(see man-pages(7)).
24:Please refer to xorg.conf(5) for general configuration
112:Xorg(1), xorg.conf(5), Xserver(1), X(7)
-.-
Additionally:
"read of a xf86... event" -> "read an xf86... event"
Originally from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095449
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 12:35:46 -07:00
Bjarni Ingi Gislason
49378eb510
exa.man: editorial changes for this man page
...
Wrong distance between sentences in the input file.
Separate the sentences and subordinate clauses; each begins on a new
line. See man-pages(7) ("Conventions for source file layout") and
"info groff" ("Input Conventions").
Mark a final abbreviation point as such by suffixing it with "\&".
25:Disables acceleration of uploading pixmap data to the framebuffer. Default: No.
-.-.
Split a punctuation mark from a single argument for a two-font macro
40:.BR xorg.conf(5).
-.-.
Section headings (.SH and .SS) do not need quoting.
38:.SH "SEE ALSO"
-.-.
Output from "test-groff -mandoc -t -K utf8 -rF0 -rHY=0 -rCHECKSTYLE=10 -ww -z ":
an.tmac:<stdin>:40: misuse, warning: .BR is for at least 2 arguments, got 1
Use macro '.B' for one argument or split argument.
Originally from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095446
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 12:25:00 -07:00
Bjarni Ingi Gislason
c7b6424eed
xorg.conf.5: Some formatting and word corrections in the manual
...
see man-pages(7) for a style manual.
Originally from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=919143
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 10:19:09 -07:00
Tanguy Ortolo
e4d2de8198
xorg.conf.man: Complete the xorg.conf.5 manpage with Option "Disable"
...
The xorg.conf.5 manpage mentions an "Enable" option to enable a monitor
regardless of whether or not it is connected, but gives no indication of how
to disable it. This patch corrects that by documenting the "Disable" option.
Orignally from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=755809
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 10:03:36 -07:00
Bjarni Ingi Gislason
1f8e32ea65
xorg.conf.man: unprotected period in ellipses
...
Originally from: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667983
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1875 >
2025-03-29 09:51:17 -07:00
Peter Hutterer
4966fbb55a
meson.build: print a summary of the DDX to build
...
Makes it easier to detect accidentally "oops, i'm not building Xwayland"
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1869 >
2025-03-24 03:05:35 +00:00
Alan Coopersmith
b73cd6066a
pkgconfig files: Add URL
...
https://github.com/pkgconf/pkgconf/blob/master/man/pc.5 says it's
a mandatory field in *.pc files.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1863 >
2025-03-09 07:32:28 +00:00
Enrico Weigelt, metux IT consult
af86c5cbc2
Xnest: use authorative declarations from X11/XKBlib.h
...
Better use the headers from the library we're linking against,
instead of having our own private declarations.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1842 >
2025-02-28 17:27:05 +00:00
Enrico Weigelt, metux IT consult
cab3856903
xfree86: os-support: fix FTBS when no recent enough libdrm found
...
On Linux, the only supported platform bus backend (*1) is via DRM/DRI.
Trying to build it w/o (recent enough) libdrm fails as it tries to
compile the drm-based implementation, w/o having drm.h available. (*2)
In order to fix this, we need to compile noop-implementation instead.
*1) platform specific code for detecting video devices
*2) https://gitlab.freedesktop.org/xorg/xserver/-/issues/1771
Issue: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1771
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1848 >
2025-02-28 16:15:32 +00:00
Enrico Weigelt, metux IT consult
e2ac461629
xfree86: platform_noop: add missing functions
...
In order to be able to build on Linux w/ platform_noop
(when no recent enough libdrm found), a few more dummy functions
are needed here.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1848 >
2025-02-28 16:15:32 +00:00
Enrico Weigelt, metux IT consult
fe9c911e22
xfree86: xf86helper: fix NULL dereference
...
xf86MatchDevice() can segfault if screensecptr->device is NULL.
Issue: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1767
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1847 >
2025-02-28 16:41:09 +01:00
Enrico Weigelt, metux IT consult
f1d87a38ae
Revert "mi: drop now obsolete mioverlay.h"
...
This reverts commit 6825f89cd2 .
Requested by Nvidia - their proprietary driver still needs it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1843 >
2025-02-27 11:53:54 +00:00
Enrico Weigelt, metux IT consult
3f469acb96
panoramix: don't install panoramiX.h and panoramiXsrv.h
...
Not used by any drivers/modules, so no need to keep them public.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1815 >
2025-02-24 20:06:30 +00:00
Enrico Weigelt, metux IT consult
573d70ae25
xwin: don't need NULL check before free()
...
free() is safe against NULL arguments.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1818 >
2025-02-23 17:32:49 +00:00
Enrico Weigelt, metux IT consult
f894801fa2
xfree86: modesetting: don't use VLA
...
even through this specific case is correct and safe, it's safer to
remove all VLA usages and forbid them completely by compiler flag.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1819 >
2025-02-20 17:26:49 +01:00
Doug Brown
a0834009cf
dri2: Protect against dri2ClientPrivate assertion failures
...
If DRI2ScreenInit hasn't been called yet, DRI2Authenticate and
DRI2CreateDrawable2 cause the X server to crash. This has been observed
to happen on multiple modern Linux distros in various conditions,
including QEMU and VMware VMs. Make these functions more robust in order
to prevent the crash.
This patch was originally provided by Bernhard Übelacker and expanded
upon by Mark Wagner.
Signed-off-by: Doug Brown <doug@schmorgal.com>
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1053
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1534
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1608 >
2025-02-19 11:25:01 +00:00
Enrico Weigelt, metux IT consult
6c88eb0cc4
misc.h: unexport compare_version()
...
Not used by any external modules, so no need to keep it in public header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1807 >
2025-02-18 11:17:40 +00:00
Enrico Weigelt, metux IT consult
804b2c081b
os: unexport CloseWellKnownConnections()
...
Not used by any modules, so no need to keep it public.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00