dc828023e8
( !1952 ) xfree86: fbdevhw: drop unused fbdevHWGetFD()
...
Not used anywhere, neither internal nor external (drivers), so no need
to keep it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
2ed036cd36
( !1952 ) xfree86: fbdevhw: drop unused fbdevHWFreeRec()
...
Not used anywhere, neither internal nor external (drivers), so no need
to keep it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
bf21374a4a
( !1952 ) xfree86: fbdevhw: make fbdevHWGetRec() static
...
Not used by any external consumers, only within the same source file,
so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
dfaa3cd823
( !1954 ) fb: unexport fbGetScreenPixmap() macro
...
No external users, so no need to keep it exported any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
372034e4d0
( !1954 ) fb: unexport fbGetGCPrivate() macro
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
8cfcf45074
( !1954 ) fb: unexport FbDash*() macros
...
No external users, so no need to keep them exported.
(note that xf86-video-intel has it's own copies of them)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
938d3057fa
( !1954 ) fb: unexport FbMaskBits() macro
...
No external users, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
68e90d3037
( !1954 ) fb: unexport FB_HEAD_BITS and FB_TAIL_BITS macros
...
Not used by any driver, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
f3c55d2a44
( !1954 ) fb: unexport FbBitsStrideToStipStride() macro
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
81d7e275aa
( !1954 ) fb: move FbStipStrideToBitsStride() to fbblt.c
...
It's only consumer is fbblt.c, so move it there.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
b896e9d911
( !1954 ) fb: move MEMCPY_WRAPPED() and MEMSET_WRAPPED() into fbblt.c
...
Only used inside fbblt.c, so we can move them into there.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
d0c39c975e
( !1954 ) fb: unexport fbListInstalledColormaps()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
edee0176c5
( !1954 ) fb: unexport fbAllocatePrivates()
...
Only used inside fb/, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
af8c9451fa
( !1954 ) fb: unexport fbSetBits()
...
Only used within fb/, not by any driver, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
8458d95001
( !1954 ) fb: unexport fbInitializeDrawable() and make it static
...
Only used inside fbpixmap.c (where it's defined), so can be static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
4cb36dd11b
( !1954 ) fb: unexport fbValidateDrawable()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
9aec81ed91
( !1954 ) fb: make fbGCFuncs static
...
Not used outside fbgc.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
5ea097f295
( !1954 ) fb: make fbGCOps static
...
Not used anywhere outside fbgc.c, so can be static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
e5eb482aa6
( !1954 ) fb: drop obsolete fbPolyFillArc and fbPolyRectangle defines
...
Those aliases haven't been used (outside fb core itself), since XAA removal
back 17 years ago, no no need to carry them in public interface any longer.
See: 703a9645f3
2025-05-22 17:34:43 +02:00
5584fa43ae
( !1954 ) fb: drop obsolete fbGetExpose() macro
...
Hasn't been used since 15 years so, probably should was forgotten to clean up.
See: bbbf795e6b
2025-05-22 17:34:43 +02:00
8d0eef1033
( !1954 ) fb: drop obsolete FbLaneCase*() macros
...
They haven't been used for over a decade now, so no need to keem'em any longer.
(note: xf86-video-intel has it's own copy of them)
2025-05-22 17:34:43 +02:00
a97128ff88
( !1954 ) fb: drop obsolete FbMaskStip macro
...
Hasn't been used since 24bpp support was dropped, almost a decade ago.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
4d1a0a9cd8
( !1954 ) fb: drop obsolete fbFillPolygon define
...
Hasn't been used since XAA removal, back 17 years ago. Probably just had been
forgotten to clean up.
See: 703a9645f3
2025-05-22 17:34:42 +02:00
c316f32a52
( !1954 ) fb: drop FbRotStipLeft, FbRotRight, FbRotStipRight macros
...
Not used anywhere, so can be dropped. Doesn't seem to be ever used
since added over two decades ago.
See: 9508a382f8
2025-05-22 17:34:42 +02:00
d133bdf3ae
( !1954 ) fb: drop commented-out FbLeftBits and FbLeftBits macros
...
Not used anywhere, so can be dropped. They always have been commented-out
since added over two decades ago.
See: 9508a382f8
2025-05-22 17:34:42 +02:00
79fc2ea1dc
( !1954 ) fb: drop obsolete FB_STIP_ODDSTRIDE and FB_STIP_ODDPTR macro()
...
Those haven't been used for over a decade now, so no need to keep
it around any longer.
See: a198373685
2025-05-22 17:34:42 +02:00
daf794b5fe
( !1955 ) Xext: geext: drop obsolete geext.h
...
This header has now become obsolete. There're also no external consumers
(drivers, etc) left, so it now finally can be dropped entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
c802304835
( !1955 ) Xext: geext: unexport GERegisterExtension() and document it
...
Not used by any external module (eg drivers), so no need to keep it
exported. Also documenting it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
fac719e416
( !1956 ) dri3: unexport VERIFY_DRI3_SYNCOBJ() macro
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
132da4fc78
( !1956 ) dri3: move dri3_syncobj_type to non-public header
...
The symbol isn't exported, thus not accessible to modules.
No need to keep it in public header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
10e220663f
( !1957 ) fb: overlay: drop unused fbOverlaySetupScreen()
...
Not used anywhere, neither internal nor drivers, so no need to keep
it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
40c15d5e73
( !1957 ) fb: overlay: make fbOverlayWindowExposures() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
dd335757e5
( !1957 ) fb: overlay: make fbOverlayCopyWindow() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ee15834d57
( !1957 ) fb: overlay: make fbOverlayUpdateLayerRegion() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
0317fb2401
( !1957 ) fb: overlay: make fbOverlayPaintKey() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ab4e175562
( !1957 ) fb: overlay: make fbOverlayCreateScreenResources() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
73d707905a
( !1957 ) fb: overlay: make fbOverlayWindowLayer() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
8c02bbdb35
( !1957 ) fb: overlay: make fbOverlayCloseScreen() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
20cc91deeb
( !1957 ) fb: overlay: make fbOverlayCreateWindow() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ccd174ee6a
( !1958 ) os: xdmcp: handle allocation failure
...
| ../os/xdmcp.c: In function ‘get_mcast_options’:
| ../os/xdmcp.c:1527:27: warning: dereference of possibly-NULL ‘mcastinfo’ [CWE-690] [-Wanalyzer-possible-null-dereference]
| 1527 | mcastinfo->ai = firstai;
| | ~~~~~~~~~~~~~~^~~~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ba7d374acf
( !1958 ) os: util: protect set_font_authorizations() from allocation failure
...
| ../os/utils.c: In function ‘set_font_authorizations’:
| ../os/utils.c:863:14: warning: dereference of possibly-NULL ‘result’ [CWE-690] [-Wanalyzer-possible-null-dereference]
| 863 | *p++ = sizeof(AUTHORIZATION_NAME) >> 8;
| | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
0f7c2cb908
( !1958 ) os: ospoll_create(): protect from allocation failure
...
| ../os/ospoll.c: In function ‘ospoll_create’:
| ../os/ospoll.c:229:22: warning: dereference of possibly-NULL ‘ospoll’ [CWE-690] [-Wanalyzer-possible-null-dereference]
| 229 | ospoll->epoll_fd = epoll_create1(EPOLL_CLOEXEC);
| | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
48f4bcde02
( !1959 ) composite: silence some warnings on possible NULL dereference
...
Unlikely to practically happen, but still safer to just check for sure.
A simple zero-value test doesn't cost us much (on modern CPUs perhaps
not even a full clock cycle).
| ../composite/compalloc.c: In function ‘compRedirectWindow’:
| ../composite/compalloc.c:167:35: warning: dereference of NULL ‘pClient’ [CWE-476] [-Wanalyzer-null-dereference]
| 167 | ccw->id = FakeClientID(pClient->index);
| | ~~~~~~~^~~~~~~
| ../composite/compalloc.c: In function ‘compUnredirectWindow’:
| ../composite/compalloc.c:331:75: warning: dereference of NULL ‘pClient’ [CWE-476] [-Wanalyzer-null-dereference]
| 331 | if (ccw->update == update && dixClientIdForXID(ccw->id) == pClient->index) {
| | ~~~~~~~^~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
71d9c0cb66
( !1960 ) exa: protect against NULL pointer dereference
...
Since GetPictureScreenIfSet() explicitly can return NULL, better be
prepared for that to happen (instead of hard crash)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
1853984d6e
( !1961 ) kdrive: protect against allocation failures and NULL pointers
...
Even if those situations shouldn't practically happen, it's better to have
some sanity checks just in case.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
60dd82ab35
( !1962 ) fb: pict: make fbGlyphs() static
...
Not used anywhere outside fbpict.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
3fd2e4d954
( !1962 ) fb: pict: unexport fbTriangles()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
8b0fc24385
( !1962 ) fb: pict: unexport fbTrapezoids()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
81318de066
( !1962 ) fb: pict: unexport fbAddTriangles()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
6f517df072
( !1962 ) fb: pict: unexport fbRasterizeTrapezoid()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
Enrico Weigelt, metux IT consult