Enrico Weigelt, metux IT consult
c885613d3b
( !1991 ) xfree86: xf86Option: unexport xf86MarkOptionUsed()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
99f022731f
( !1991 ) xfree86: xf86Option: unexport xf86OptionListReport()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
4e1885f3d5
( !1991 ) xfree86: xf86Option: make xf86CheckIfOptionUsedByName() static
...
Only used inside of xf86Option.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
529deae922
( !1991 ) xfree86: xf86Option: drop unused xf86CheckIfOptionUsed()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
b697b2bc51
( !1991 ) xfree86: xf86Option: drop unused xf86ReplacePercentOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
6696742112
( !1991 ) xfree86: xf86Option: drop unused xf86ReplaceRealOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
fcd70be3ed
( !1991 ) xfree86: xf86Option: drop unused xf86GetOptValReal()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
3db4b3ddde
( !1991 ) xfree86: xf86Option: drop unused xf86NewOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:35 +02:00
Enrico Weigelt, metux IT consult
8d87849774
( !1991 ) xfree86: xf86Option: drop unused xf86CheckRealOption()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5e5bc4edf9
( !1992 ) xfree86: i2c: drop unused xf86I2CWriteWord()
...
Not used anywhere, so no need to keep around it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
7e6b7b03a5
( !1992 ) xfree86: i2c: drop unused xf86I2CWriteBytes()
...
Not used anywhere, so no need to keep around it any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
aadaaa2161
( !1992 ) xfree86: i2c: drop unused xf86I2CReadWord()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
f6aed15f68
( !1992 ) xfree86: i2c: drop unused xf86I2CReadStatus()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
9747f56329
( !1993 ) xfree86: vbe: drop dead code
...
This never seemed to be actually enabled, just ifdef'ed out, so no
need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
bec4f5a510
( !1993 ) xfree86: vbe: drop unused VBEGetVBEpmi()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
b168365763
( !1993 ) xfree86: vbe: drop unused VBEGetDisplayStart()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
ed56bb9752
( !1994 ) xfree86: ddc: make DMTModes[] static
...
Only used inside xf86EdidModes.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
83301fa98f
( !1994 ) xfree86: ddc: make FindDMTMode() static
...
Only used inside xf86EdidModes.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
e15cb124fd
( !1994 ) xfree86: ddc: unexport gtf_supported()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
3a0fa92f4e
( !1994 ) xfree86: ddc: drop unused xf86MonitorIsHDMI()
...
Not used anywhere, so no need to keep it anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
893409e09d
( !1994 ) xfree86: ddc: unexport xf86EdidMonitorSet()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
9fd2de407d
( !1995 ) xfree86: xisb: drop unused XisbTrace()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
1c3e21694a
( !1995 ) xfree86: xisb: drop unused XisbWrite()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
85914d59ba
( !1996 ) xfree86: xv: unexport XF86XvScreenKey
...
Not used by any drivers, and the include is private anyways.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
22904a4c43
( !1996 ) xfree86: xv: don't install xf86xvpriv.h
...
Not included by any drivers, and it's supposed to be private anyways.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
3d04c302a9
( !1996 ) xfree86: xv: drop unused xf86XVFillKeyHelperPort()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
b7b7ed9f13
( !1997 ) xfree86: fbman: move FBManagerFuncs into x86fbman.c
...
Only used here, so no need to keep it in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
458bfb9b3c
( !1997 ) xfree86: fbman: make xf86InitFBManagerRegion() static
...
Only called locally within xf86fbman.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
d276caae83
( !1997 ) xfree86: fbman: make xf86RegisterOffscreenManager()
...
Only called locally within xf86fbman.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5104bae723
( !1997 ) xfree86: fbman: drop FreeBoxesUpdateCallback
...
Nobody fills it anymore, so not needed at all anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5da301d8a4
( !1997 ) xfree86: fbman: drop RegisterFreeBoxCallback proc pointer
...
Nobody calls it anymore, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
6b8b67aba0
( !1997 ) xfree86: fbman: drop unused xf86RegisterFreeBoxCallback()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
928e5bea2b
( !1997 ) xfree86: fbman: drop unused xf86AllocateLinearOffscreenArea()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
7f9f9e8e73
( !1997 ) xfree86: fbman: drop unused xf86FBManagerRunning()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
e66697088f
( !1997 ) xfree86: fbman: drop unused xf86InitFBManagerArea()
...
Not used anywhere, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
26e67421cc
( !1988 ) xfree86: loader: drop unused MODULETEARDOWNPROTO() macro
...
Not used anywhere, so no need to keep it in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
5f87a8a290
( !1998 ) xfree86: loader: drop unused GET_MODULE_*_VERSION macros
...
Not used anywhere, so no need to keep them around in public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
b1f96da24c
( !1999 ) include: os: add returns_nonnull attribute to XNFalloc/XNFcallocarray
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
d6e1efa3c1
( !2000 ) xfree86: drop ifdefs on _NO_XF86_PROTOTYPES
...
Nothing ever sets this symbol, so can be dropped.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
f1aef90aeb
( !2001 ) Xi: exevents: drop unused retvals on TryClientEvents() calls
...
The return values aren't used anywhere, so the assignment is not necessary.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
2cd1b1b376
( !2002 ) dix: drop unused SetVendorRelease()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:34 +02:00
Enrico Weigelt, metux IT consult
60b6b9ab7d
( !2003 ) dix: replace AtomError() by better messages
...
Not used by any exteral drivers (and really should not be used by them),
so can be replaced by more fitting error messages.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:23 +02:00
Alan Coopersmith
7aa1f121e4
mi: use common implementation of bit counting function
...
Reduce a bit of unexplained magic, and use ISA extensions where available
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1984 >
2025-05-20 00:34:23 +00:00
Enrico Weigelt, metux IT consult
73f3c47608
randr: fix unconditional byte-swap in ProcRRGetProviderInfo()
...
The list of the associated provider's capabilities was always swapped
unconditionally, while it should only be in case of client having
opposite endianess.
Fixes: 426bc0a28e
Reported-By: dasha_uwu
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1977 >
2025-05-18 23:42:19 +00:00
Enrico Weigelt, metux IT consult
f0fd9f8bf4
dix: fix warning on redefinition of typedefs
...
| ../dix/input_priv.h:56:29: warning: redefinition of typedef 'InputOption' is a C11 feature [-Wtypedef-redefinition]
| 56 | typedef struct _InputOption InputOption;
| | ^
| ../include/input.h:255:29: note: previous definition is here
| 255 | typedef struct _InputOption InputOption;
| | ^
| In file included from ../hw/xfree86/common/xf86Cursor.c:36:
| ../dix/input_priv.h:57:25: warning: redefinition of typedef 'XI2Mask' is a C11 feature [-Wtypedef-redefinition]
| 57 | typedef struct _XI2Mask XI2Mask;
| | ^
| ../include/input.h:256:25: note: previous definition is here
| 256 | typedef struct _XI2Mask XI2Mask;
| | ^
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1978 >
2025-05-18 17:35:31 +00:00
Olivier Fourdan
b97b459c06
xwayland: Update sprite prior to clearing the focus window
...
Xwayland has its own XYToWindow() handler to account for the case when
the pointer leaves an X11 surface to enter another Wayland native window
(which of course are unknown to Xwayland).
When that occurs, Xwayland will treat it as if the pointer had entered
the root window so that the X11 clients receive an appropriate leave
event.
When the pointer leaves the X11 surface, Xwayland will call
CheckMotion() to update the sprite coordinates and possibly the cursor.
However, CheckMotion() will call back into the XYToWindow() handler,
which will then pretend the window has entered the root window, and that
may cause the wrong cursor to be applied.
To avoid the issue, change the order we do things, by calling
CheckMotion() first prior to clear up the internal focus window so that
the first call to XYToWindow() will return the correct X11 window so we
get to update the cursor correctly.
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1811
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1915 >
2025-05-16 10:02:53 +00:00
Alan Coopersmith
37b7ea8f8a
render: miindex.c does not need header guard macros
...
Clears warning from clang 19.1.7:
render/miindex.c:27:9: warning: macro is not used [-Wunused-macros]
27 | #define _MIINDEX_H_
| ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:16 +00:00
Alan Coopersmith
f988558348
os: remove unused definition of BUGADDRESS
...
We stopped including this in error messages back in 2008
Clears warning from clang 19.1.7:
os/utils.c:1338:9: warning: macro is not used [-Wunused-macros]
1338 | #define BUGADDRESS BUILDERADDR
| ^
Fixes: ef77e4c44
("Remove useless commentary from environment and argument processing.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:16 +00:00
Alan Coopersmith
d1cc5a599f
test: remove extra return
...
Clears warning from clang 19.1.7:
test/misc.c:239:12: warning: 'return' will never be executed
[-Wunreachable-code-return]
239 | return 0;
Fixes: 46b579e8d
("test: switch the unit tests to something resembling a test suite")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:15 +00:00
Alan Coopersmith
14e202d6a0
xfixes: cursor.c should include header for CursorVisible & EnableCursor
...
Clears warnings from clang 19.1.7:
xfixes/cursor.c:132:6: warning: no previous extern declaration for
non-static variable 'CursorVisible' [-Wmissing-variable-declarations]
132 | Bool CursorVisible = FALSE;
| ^
xfixes/cursor.c:133:6: warning: no previous extern declaration for
non-static variable 'EnableCursor' [-Wmissing-variable-declarations]
133 | Bool EnableCursor = TRUE;
| ^
Fixes: 2cec3cfbf
("include: move private definitions out of input.h")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1910 >
2025-04-19 17:02:15 +00:00