b30edf326b
fix missing includes of <X11/Xfuncproto.h>
...
Several places using _X_ATTRIBUTE_PRINTF macro from X11/Xfuncproto.h
but missing to include it, so it depends on other headers whether it's
included by mere accident, which quickly causes trouble if include order
changes. Cleaning that up by adding explicit include statements.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1580 >
2024-07-20 17:18:38 +00:00
a6a993f950
os: Fix siHostnameAddrMatch in the case where h_addr isn't defined
...
When IPv6 support isn't enabled, and h_addr isn't defined,
there is no for loop, so the break statement is invalid.
Signed-off-by: Joaquim Monteiro <joaquim.monteiro@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1572 >
2024-06-23 21:32:23 +00:00
0ddcd87851
os: Fix assignment with incompatible pointer type
...
struct hostent->h_addr_list is of type char**, not const char**.
GCC considers this an error when in C99 mode or later.
Signed-off-by: Joaquim Monteiro <joaquim.monteiro@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1572 >
2024-06-23 21:32:23 +00:00
34662f15af
os: unexport fields from opaque.h not used by modules / drivers
...
There're lots of field that aren't used by any modules or drivers,
thus no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1351 >
2024-06-23 21:19:27 +00:00
06b599edb6
dix: unexport fields from opaque.h not used by modules/drivers
...
Lots of fields from opaque.h aren't used by any drivers/modules and thus
don't need to be exported at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1351 >
2024-06-23 21:19:27 +00:00
591d95c79e
xace: typesafe hook function for XACE_AUTH_AVAIL
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
47d6c3ad75
xace: typesafe hook function for XACE_SERVER_ACCESS
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
487eb46826
os: move xserver_poll.h into os/ directory
...
This header isn't public and holds defines for code in os/ directory,
so no need to keep it in the global header dir - it's probably better
off in os/ directory - just like we already have with many others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1389 >
2024-06-21 00:53:39 +00:00
f8057261fe
os: drop extra ifdefs for AF_INET6
...
Since IPv6 is now only defined if IPv6 is really supported, we don't
need to ifdef on AF_INET6 anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1539 >
2024-06-18 01:59:33 +00:00
88b2257cc4
os: drop duplicate nested ifdef TCPCONN
...
This #ifdef is always true, since two lines above it's already
checked that TCPCONN is defined.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1539 >
2024-06-18 01:59:33 +00:00
9d6a1d1118
os: access.c: drop unnecessary ifdef
...
Conditional on ipv6 around including <arpa/inet.h> isn't necessary.
The only reason target not having it is win32, but it doesn't enable
SIOCGLIFCONF anyways.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1539 >
2024-06-18 01:59:33 +00:00
71b207a2eb
os: drop SUN-DES-1 authentication
...
DES isn't considered secure anymore for long time now, more and more platforms
dropping DES from their RPC implementations, and even the one where it came
from (Solaris) disabled it for a decade now. We have much better alternatives
(eg. passing creds via Unix socket for local connections, ssh tunneling,
MIT-MAGIC-COOKIE-1, ...), so it's unlikely anybody still really relying on it.
Therefore, sweep it out.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1453 >
2024-06-18 00:52:11 +00:00
af6180b2c9
os: Explicitly include X11/Xmd.h for CARD32 definition to fix building on i686
...
Noticed this after trying to update to xorg-server-xwayland-24.1.0 in void linux https://github.com/void-linux/void-packages/pull/50457
Signed-off-by: Fotios Valasiadis <fvalasiad@gmail.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1561 >
2024-06-07 08:42:58 +00:00
61d0c8e21c
os: drop duplicate include of misc.h
...
Need to include it only once.
Fixes: be4c8444ebhttps://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1542 >
2024-05-13 19:23:08 +00:00
a4cb4bc4f8
os: drop remains of STREAMSCONN
...
STREAMSCONN has been removed about a decade ago, but some comments
have been forgotten to be cleaned.
Fixes: b3e9c534e2https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1538 >
2024-05-13 18:20:55 +02:00
e5c8b664d3
os: unexport ddx callbacks
...
The DDX callbacks (where core/DIX calls into DDX) aren't supposed to be
called by drivers directly, so unexport them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1332 >
2024-05-08 09:37:35 +02:00
bae6cbc8ca
include: move private defs to dixstruct_priv.h
...
Public server module API shouldn't be clobbered with private definitions,
thus move them out to dixstruct_priv.h
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1289 >
2024-04-30 00:47:38 +00:00
620b678cfe
os: secure-rpc: make build option tristate
...
Add support `auto` mode, which only enables secure-rpc when
dependencies are met.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1441 >
2024-04-17 23:38:25 +00:00
339717bac6
os: secure-rpc: check struct authdes_cred
...
Some platforms (eg. NetBSD) don't have DES support in rpc anymore, so we
should check, in order to prevent weird, hard to understand build breaks.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1441 >
2024-04-17 23:38:25 +00:00
d2d3f4a700
os: define SECURE_RPC locally instead of global config header
...
Since this define is only used inside os subdir, move the definition there
and out of the global config header. This also makes some further steps,
e.g. checking whether it's supported, a litle bit easier.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1441 >
2024-04-17 23:38:25 +00:00
c17c527b9a
os: unexport ForceClockId()
...
This function is only intended for DDX'es (currently just Xwayland) that
need to force using another clock. Really shouldn't be called by drivers
or extensions.
Fixes: a779fda224https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1333 >
2024-04-17 16:20:54 -07:00
a0b69624f7
os: unexport ListenToAllClients()
...
It's just called by DIX, not by any drivers/modules, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1387 >
2024-04-16 18:23:27 -07:00
d18ef33099
os: unexport OnlyListenToOneClient()
...
Not used by any drivers, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1385 >
2024-04-16 18:13:11 -07:00
4c1795701c
os: unexport MakeClientGrabPervious() and MakeClientGrabImpervious()
...
Not used by any drivers, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1384 >
2024-04-16 17:52:14 -07:00
be4c8444eb
os: unexport Os*() functions
...
These aren't called (and suited for being called) by drivers,
thus drop them from the public module API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1381 >
2024-04-16 14:20:30 +02:00
3aa62ca6f0
os: fix missing include of misc.h in busfault.h
...
busfault.h is using FALSE, but didn't include misc.h, so it really
depends on include order whether it works.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1381 >
2024-04-16 14:19:59 +02:00
76d01e9bf6
os: unexport OsVendorVErrorFProc pointer
...
This pointer allows a DDX to install it's own error print handler. It's really
only intended for DDXes, thus no need to have it exported to modules.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1369 >
2024-04-15 23:59:38 +00:00
1999785fa9
os: move over osLookupColor to dix
...
This function is only used by DIX and not os-specific at all.
So move it over to DIX and give it a more fitting name.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1373 >
2024-04-15 16:19:30 -07:00
6cb599f59c
os: unexport OsLookupColor()
...
It's an internal function, only used by DIX, not by drivers and shouldn't
have been exported in the first place.
Fixes: 49f77fff14https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1373 >
2024-04-15 16:19:06 -07:00
3b7a63e6ae
os: unexport xthread_sigmask
...
This function isn't used by drivers and there's currently no need to do so,
thus keep it out of the public module API.
Fixes: 30ac756798https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1368 >
2024-04-15 22:49:02 +00:00
cf5fab0bbe
os: unexport AccessUsingXdmcp()
...
This function is only used internally for xdmcp auth handling, not used
in modules/drivers, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
dd21a80219
os: unexport ChangeAccessControl()
...
this function isn't used by modules/drivers, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
3f00c1b6cf
os: unexport host control functions
...
these aren't used by modules/drivers, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
5a9b885118
os: unexport authorization management functions
...
Those aren't used by modules, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
bed778ee60
os: unexport LocalAccessScopeUser()
...
this function is only used by wayland ddx, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
e621081fa3
os: unexport EnableLocalUser() and DisableLocalUser()
...
these aren't used by module, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:55:22 -07:00
54441ff98a
os: unexport EnableLocalAccess() and DisableLocalAccess()
...
these aren't used by modules, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:44:36 -07:00
b00fdd482c
os: unexport EnableLocalHost() and DisableLocalHost()
...
These aren't used by modules, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:44:36 -07:00
5f19eab1ee
os: unexport local client creds handling
...
these functions aren't used by modules, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:44:34 -07:00
cbc9f557e5
os: unexport set_font_authorizations()
...
This function is only used by DIX, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1344 >
2024-04-15 14:42:45 -07:00
389b528203
os: unexport command line args handling functions
...
These functions shouldn't be called by drivers or extensions, thus
shouldn't be exported. Also moving it to separate header, so the
already huge ones aren't cluttered with even more things.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1334 >
2024-04-15 21:21:40 +00:00
dae76bbaaf
include: move busfault.h out of public include dir
...
this header is isn't public, so it's more appropriate, where the actual
code is, which is the os/ directory.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1337 >
2024-04-15 21:10:15 +00:00
3843a643e0
os: unexport audit functions
...
These aren't used by any drivers, so no need to keep them around in the
public driver API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1326 >
2024-04-15 19:54:34 +00:00
eac10cf1fa
os: connection: drop obsolete define Pid_t
...
Clean up a yet some more stale leftovers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1260 >
2024-04-15 18:02:11 +00:00
537293ff4e
os: move SELinux enforcement state to the extension
...
Those fields are better off in the extension instead of the OS layer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1328 >
2024-03-25 19:40:04 +00:00
8dc82a13a9
os: rpc: fix type mismatch
...
fix warning:
> ../os/rpcauth.c:159:16: warning: result of comparison of constant -1 with expression of type 'XID' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
> if (rpc_id == ~0L)
> ~~~~~~ ^ ~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1431 >
2024-03-21 22:57:40 +00:00
dfa606d5a4
os: fix missing include of <errno.h>
...
It's much cleaner to always include directly what one needs,
instead of relying on very indirect including.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1435 >
2024-03-21 17:32:30 +01:00
924939c886
Revert "Fix missing includes of <errno.h>"
...
Removing errno from xf86_OSlib.h breaks the xf86-input-mouse driver
build. And xf86_OSlib.h itself relies on errno anyway in the SYSCALL
macro provided by this header.
This reverts commit f6a367102chttps://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1423 >
2024-03-19 00:33:26 +00:00
ccfa7e9f2e
Fix missing include of <sys/wait.h>
...
Instead of relying on indirect includes, it's much cleaner if everybody
includes directly what he needs.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1419 >
2024-03-18 23:02:45 +00:00
f6a367102c
Fix missing includes of <errno.h>
...
It's much cleaner to always include directly what one needs,
instead of relying on very indirect including.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1416 >
2024-03-18 22:58:32 +00:00
Enrico Weigelt, metux IT consult
Joaquim Monteiro
Fotios Valasiadis
Peter Hutterer