c0d068229b
xfree86: common: extra safety checks for NULL pointers
...
Even though it's unlikely ever getting it, still safer to have some
extra checks / asserts than unexpected segfault.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:45 +02:00
aad59c6dee
xfree86: common: fix not-found check in xf86platformAddDevice()
...
Safer (and easier to understand) if we look at the result pointer
instead of the counter for testing whether device wasn't found.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:42 +02:00
d3c4e100ed
xfree86: common: gracefully handle allocation failure
...
Better try to handle memory allocation gracefully than just hard
crashing by segfault.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:40 +02:00
111ca8af21
xfree86: utils: gracefully handle allocation failure.
...
Better failing gracefully instead of hard crash via segfault.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:37 +02:00
6c9f2ecc32
xfree86: int10: extra NULL protection
...
Even though chances are really low it's ever getting hit, it's still safer
to have some sanity checks (which don't cost us much) than risking segfault.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:34 +02:00
30c60ed578
xfree86: modes: fix uninitialized variables
...
| ../hw/xfree86/modes/xf86RandR12.c: In function ‘xf86ComputeCrtcPan’:
| ../hw/xfree86/modes/xf86RandR12.c:310:54: warning: use of uninitialized value ‘r[1]’ [CWE-457] [-Wanalyzer-use-of-uninitialized-value]
| 310 | q[i] = m->m[1][i] * r[0] - m->m[0][i] * r[1];
| | ~^~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:32 +02:00
7ae09df3ae
xfree86: loader: add assert() in LoadModule()
...
There's (remote) chance that the (internal) module name could become
NULL (eg. allocation failure). Even though chances to hit it are very
low, it's still better to have a check here (that doesn't cost us much),
just in case. Assert fail is still better than segfault, since we're
at least getting some hint what might have happened.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:29 +02:00
b28285332e
xfree86: parser: check for alloc failure and possible NULL pointers
...
Adding paranoid extra checks against allocation failure and NULL pointers.
Even though might not be actually hit in practise, it's still better to
be cautious, just in case. And reducing analyzer noise this way.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:26 +02:00
88d561bf18
xfree86: x86emu: add extra assert()'s
...
The analyzer warnings (possible NULL dereference) are probably just
false alarms. But for safety adding assert()'s, which don't cost us
anything in non-debug builds.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:24 +02:00
6a01f488c8
os: drop self-limiting resources
...
It's only rarely used and can be easily achieved by generic means,
eg. via ulimit or supervisor settings.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:31:57 +02:00
1c088613ba
include: don't install propertyst.h
...
Nothing in here needs anything from that include file, so no need for
including it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:31:02 +02:00
73d2d99ace
xfree86: xf86Priv.h: dont include propertyst.h
...
Nothing in here needs anything from that include file, so no need for
including it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:30:45 +02:00
505138167e
xfree86: xf86.h: dont include propertyst.h
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:30:20 +02:00
9d98f3a7ca
xfree86: xf86Events.c: add missing include of property.h
...
the file calls some functions from property.h, so it needs to be included.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:30:16 +02:00
1e7752f10d
randr: unexport and document RRProviderAutoConfigGpuScreen()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:29:30 +02:00
55474ddf66
randr: unexport and document RROutputSetSubpixelOrder()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:28:53 +02:00
c9a1dd9281
randr: unexport and document RRHasScanoutPixmap()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:28:15 +02:00
eb297d3443
randr: unexport and document RRCrtcDetachScanoutPixmap()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:28:07 +02:00
03ea1c6ec0
randr: unexport and document RRCrtcDestroy()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:27:56 +02:00
4a5fa21098
randr: unexport and document RRResourcesChanged()
...
Not used by external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:27:26 +02:00
d0d4ced9d3
glamor: unexport glamor_set_glvnd_vendor()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:25:01 +02:00
999ed88818
glamor: unexport glamor_set_pixmap_texture()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:54 +02:00
8766d2b54d
ephyr: workaround for name clash between Xlib and Xserver
...
A slight change in include order can cause Xlib to be included and defining
"GC" type, which is conflicting with Xserver's own type by same name.
As long as MR !1393 hasn't merged yet, we need to do an ugly workaround
using some preprocessor black magic.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:36 +02:00
90003b42b6
xfree86: drop xf86VGAarbiter.h
...
It doesn't serve any practical purpose anymore and also isn't included
by any external driver, thus also no need to keep it in SDK.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:32 +02:00
4e38c99155
xfree86: unexport xf86VGAarbiterAllowDRI()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:29 +02:00
b20ef5b181
xfree86: drop obsolete xf86VGAarbiterDeviceDecodes()
...
Not used by anybody, so no need to keep it anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:26 +02:00
b31b4c0ae2
xwayland: protect against alloc failures and NULL pointers
...
Protecting against NULL pointers and allocation failures.
Printing out a bug warning in those cases.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:22 +02:00
ffa080cdf0
xfree86: unexport xf86RemoveInputEventDrainCallback()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:15 +02:00
885cab379b
xfree86: unexport xf86AddInputEventDrainCallback()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:12 +02:00
78df73b627
xfree86: unexport xf86LookupInput()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:08 +02:00
d345549372
xfree86: unexport xf86LookupInputDriver()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:05 +02:00
b700c6c81d
xfree86: unexport xf86InputEnableVTProbe()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:24:02 +02:00
e16424212e
xfree86: unexport xf86PostButtonEventM()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:59 +02:00
2184917646
xfree86: make xf86VIDrvMsgVerb() static
...
Only used inside xf86Helper.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:55 +02:00
2cfde50bac
xfree86: make xf86PostKeyEvent() static
...
Only used inside xf86Xinput.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:52 +02:00
ef8a427e36
xfree86: drop obsolete xf86PostKeyEventM()
...
It's now only a wrapper calling xf86PostKeyEvent(), and no external driver
using it anymore, so we can drop it entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:48 +02:00
dba821515b
xfree86: drop unused xf86DeleteInputDriver()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:45 +02:00
f89b48962d
xfree86: drop unused xf86EnableDevice()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:42 +02:00
77d254cb8b
xfree86: drop unused xf86PostKeyEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:38 +02:00
b79112e1bf
xfree86: drop unused xf86PostProximityEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:35 +02:00
fd80169cfe
xfree86: drop unused xf86PostMotionEventP()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:32 +02:00
bf27c3441f
xfree86: xf86Option: unexport xf86MarkOptionUsedByName()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:28 +02:00
3ee128c0e1
xfree86: xf86Option: unexport xf86MarkOptionUsed()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:25 +02:00
2d12c1285f
xfree86: xf86Option: unexport xf86OptionListReport()
...
Not used by any external drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:22 +02:00
167cefbec4
xfree86: xf86Option: make xf86CheckIfOptionUsedByName() static
...
Only used inside of xf86Option.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:18 +02:00
ed6517ac54
xfree86: xf86Option: drop unused xf86CheckIfOptionUsed()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:14 +02:00
150c8ed6ce
xfree86: xf86Option: drop unused xf86ReplacePercentOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:11 +02:00
d2e10b1c98
xfree86: xf86Option: drop unused xf86ReplaceRealOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:08 +02:00
228cdd3bfe
xfree86: xf86Option: drop unused xf86GetOptValReal()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:04 +02:00
b2425861a2
xfree86: xf86Option: drop unused xf86NewOption()
...
Not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:23:01 +02:00
Enrico Weigelt, metux IT consult