d29600412f
(1823) fb: replace xallocarray() by calloc()
...
Only key difference that calloc(), in contrast to rellocarray(),
is zero-initializing. The overhead is hard to measure on today's
machines, and it's safer programming practise to always allocate
zero-initialized, so one can't forget to do it explicitly.
Cocci rule:
@@
expression COUNT;
expression LEN;
@@
- xallocarray(COUNT,LEN)
+ calloc(COUNT,LEN)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:59 +02:00
73c1ce2463
( !1909 ) fb: use calloc() instead of malloc()
...
Using calloc() instead of malloc() as preventive measure, so there
never can be any hidden bugs or leaks due uninitialized memory.
The extra cost of using this compiler intrinsic should be practically
impossible to measure - in many cases a good compiler can even deduce
if certain areas really don't need to be zero'd (because they're written
to right after allocation) and create more efficient machine code.
The code pathes in question are pretty cold anyways, so it's probably
not worth even thinking about potential extra runtime costs.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:49 +02:00
ad1802015d
( !1944 ) treewide: drop COMPOSITE symbol
...
It's always enabled for very long time now (at least since meson transition),
there doesn't seem to be any need to ever disable it again. So we can reduce
code complexity by removing all the ifdef's.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:47 +02:00
dfaa3cd823
( !1954 ) fb: unexport fbGetScreenPixmap() macro
...
No external users, so no need to keep it exported any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
372034e4d0
( !1954 ) fb: unexport fbGetGCPrivate() macro
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
8cfcf45074
( !1954 ) fb: unexport FbDash*() macros
...
No external users, so no need to keep them exported.
(note that xf86-video-intel has it's own copies of them)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
938d3057fa
( !1954 ) fb: unexport FbMaskBits() macro
...
No external users, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
68e90d3037
( !1954 ) fb: unexport FB_HEAD_BITS and FB_TAIL_BITS macros
...
Not used by any driver, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
f3c55d2a44
( !1954 ) fb: unexport FbBitsStrideToStipStride() macro
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
81d7e275aa
( !1954 ) fb: move FbStipStrideToBitsStride() to fbblt.c
...
It's only consumer is fbblt.c, so move it there.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
b896e9d911
( !1954 ) fb: move MEMCPY_WRAPPED() and MEMSET_WRAPPED() into fbblt.c
...
Only used inside fbblt.c, so we can move them into there.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
d0c39c975e
( !1954 ) fb: unexport fbListInstalledColormaps()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
edee0176c5
( !1954 ) fb: unexport fbAllocatePrivates()
...
Only used inside fb/, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
af8c9451fa
( !1954 ) fb: unexport fbSetBits()
...
Only used within fb/, not by any driver, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
8458d95001
( !1954 ) fb: unexport fbInitializeDrawable() and make it static
...
Only used inside fbpixmap.c (where it's defined), so can be static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
4cb36dd11b
( !1954 ) fb: unexport fbValidateDrawable()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
9aec81ed91
( !1954 ) fb: make fbGCFuncs static
...
Not used outside fbgc.c, so can be made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
5ea097f295
( !1954 ) fb: make fbGCOps static
...
Not used anywhere outside fbgc.c, so can be static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
e5eb482aa6
( !1954 ) fb: drop obsolete fbPolyFillArc and fbPolyRectangle defines
...
Those aliases haven't been used (outside fb core itself), since XAA removal
back 17 years ago, no no need to carry them in public interface any longer.
See: 703a9645f3
2025-05-22 17:34:43 +02:00
5584fa43ae
( !1954 ) fb: drop obsolete fbGetExpose() macro
...
Hasn't been used since 15 years so, probably should was forgotten to clean up.
See: bbbf795e6b
2025-05-22 17:34:43 +02:00
8d0eef1033
( !1954 ) fb: drop obsolete FbLaneCase*() macros
...
They haven't been used for over a decade now, so no need to keem'em any longer.
(note: xf86-video-intel has it's own copy of them)
2025-05-22 17:34:43 +02:00
a97128ff88
( !1954 ) fb: drop obsolete FbMaskStip macro
...
Hasn't been used since 24bpp support was dropped, almost a decade ago.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:43 +02:00
4d1a0a9cd8
( !1954 ) fb: drop obsolete fbFillPolygon define
...
Hasn't been used since XAA removal, back 17 years ago. Probably just had been
forgotten to clean up.
See: 703a9645f3
2025-05-22 17:34:42 +02:00
c316f32a52
( !1954 ) fb: drop FbRotStipLeft, FbRotRight, FbRotStipRight macros
...
Not used anywhere, so can be dropped. Doesn't seem to be ever used
since added over two decades ago.
See: 9508a382f8
2025-05-22 17:34:42 +02:00
d133bdf3ae
( !1954 ) fb: drop commented-out FbLeftBits and FbLeftBits macros
...
Not used anywhere, so can be dropped. They always have been commented-out
since added over two decades ago.
See: 9508a382f8
2025-05-22 17:34:42 +02:00
79fc2ea1dc
( !1954 ) fb: drop obsolete FB_STIP_ODDSTRIDE and FB_STIP_ODDPTR macro()
...
Those haven't been used for over a decade now, so no need to keep
it around any longer.
See: a198373685
2025-05-22 17:34:42 +02:00
10e220663f
( !1957 ) fb: overlay: drop unused fbOverlaySetupScreen()
...
Not used anywhere, neither internal nor drivers, so no need to keep
it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
40c15d5e73
( !1957 ) fb: overlay: make fbOverlayWindowExposures() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
dd335757e5
( !1957 ) fb: overlay: make fbOverlayCopyWindow() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ee15834d57
( !1957 ) fb: overlay: make fbOverlayUpdateLayerRegion() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
0317fb2401
( !1957 ) fb: overlay: make fbOverlayPaintKey() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
ab4e175562
( !1957 ) fb: overlay: make fbOverlayCreateScreenResources() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
73d707905a
( !1957 ) fb: overlay: make fbOverlayWindowLayer() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
8c02bbdb35
( !1957 ) fb: overlay: make fbOverlayCloseScreen() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
20cc91deeb
( !1957 ) fb: overlay: make fbOverlayCreateWindow() static
...
Not used anywhere outside fboverlay.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
60dd82ab35
( !1962 ) fb: pict: make fbGlyphs() static
...
Not used anywhere outside fbpict.c, so can become static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
3fd2e4d954
( !1962 ) fb: pict: unexport fbTriangles()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
8b0fc24385
( !1962 ) fb: pict: unexport fbTrapezoids()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
81318de066
( !1962 ) fb: pict: unexport fbAddTriangles()
...
Not used by drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
6f517df072
( !1962 ) fb: pict: unexport fbRasterizeTrapezoid()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-05-22 17:34:42 +02:00
08ec122fa7
fb: use dixDestroyPixmap() instead of direct driver call
...
Direct calls to ScreenRec->DestroyPixmap() blocks cleaning up the wrapping
jungle, so use the proper dix function instead.
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1711 >
2025-02-12 17:48:30 +01:00
c3c538784a
mi: unexport miExpandDirectColors()
...
Not used by any drivers/modules, so no need to keep it public.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1727 >
2025-02-06 16:45:20 +02:00
e424f49cdb
mi: unexport miWindowExposures()
...
Not used by any modules/drivers, so no need to keep it public.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1727 >
2025-02-06 16:45:20 +02:00
4cd7e2e819
Revert "fb: Declare wfbFinishScreenInit, wfbScreenInit for !FB_ACCESS_WRAPPER"
...
This reverts commit 34a430a16ehttps://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1720 >
2024-11-08 17:42:09 +00:00
1642adec3b
dix: unexport Ones()
...
It's not used by any module/driver, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1695 >
2024-10-26 16:35:57 +00:00
a917f6a8a8
drop obsolete HAVE_DIX_CONFIG_H
...
The symbol controls whether to include dix-config.h, and it's always set,
thus we don't need it (and dozens of ifdef's) anymore.
This commit only removes them from our own source files, where we can
guarantee that dix-config.h is present - leaving the (potentially exported)
headers untouched.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2024-10-10 13:38:31 +00:00
b48e4a9cb7
dix: unexport AllocColor()
...
Not used by any driver/module, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1581 >
2024-09-01 22:06:49 +00:00
368055d3f1
render: move private definitions out of public glyphstr.h
...
Public module API headers don't need / shouldn't to contain anything that
isn't part of the API (non-exported functions, etc).
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1287 >
2024-03-03 22:54:16 +00:00
f2b019d2b3
fb: Fix 1bpp Xservers on "whitePixel=0, blackPixel=1" VRAMs
...
Closes : #1057
2024-01-03 19:43:16 +00:00
7b1758936b
Revert "fb: Remove even/odd tile slow-pathing"
...
This reverts commit e572bcc7f4Closes : #1056
2023-04-19 15:33:59 +00:00
Enrico Weigelt, metux IT consult
Sérgio Basto
Izumi Tsutsui