dix: AllocColor() dont fire Xace hook when looking up color at root window

This is creating false alarms that are complicated to catch, thus passing NULL client so the Xace hook in dixLookupResourceByType() doesn't fire here. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-03-19 11:02:21 +01:00
1 changed files with 2 additions and 2 deletions
--- a/dix/colormap.c
+++ b/dix/colormap.c
@ -1026,7 +1026,7 @@ AllocColor(ColormapPtr pmap,

            dixLookupResourceByType((void **) &prootmap,
                                    pmap->pScreen->defColormap, X11_RESTYPE_COLORMAP,
-                                    clients[client], DixReadAccess);
+                                    NULL, DixReadAccess);

            if (pmap->class == prootmap->class)
                FindColorInRootCmap(prootmap, prootmap->red, entries, &rgb,
@ -1044,7 +1044,7 @@ AllocColor(ColormapPtr pmap,

            dixLookupResourceByType((void **) &prootmap,
                                    pmap->pScreen->defColormap, X11_RESTYPE_COLORMAP,
-                                    clients[client], DixReadAccess);
+                                    NULL, DixReadAccess);

            if (pmap->class == prootmap->class) {
                pixR = (*pPix & pVisual->redMask) >> pVisual->offsetRed;