XLibre Xserver
Go to file
Samuel Thibault 0217cc6e0c xkb: fix XkbSetMap when changing a keysym without changing a keytype
As the comment says:

"symsPerKey/mapWidths must be filled regardless of client-side flags"

so we always have to call CheckKeyTypes which will notably fill mapWidths
and nTypes. That is needed for CheckKeySyms to work since it checks the
width. Without it, any request with XkbKeySymsMask but not
XkbKeyTypesMask will fail because of the missing width information, for
instance this:

  XkbDescPtr xkb;
  if (!(xkb = XkbGetMap (dpy, XkbKeyTypesMask|XkbKeySymsMask, XkbUseCoreKbd))) {
    fprintf (stderr, "ERROR getting map\n");
    exit(1);
  }
  XFlush (dpy);
  XSync (dpy, False);

  XkbMapChangesRec changes = { .changed = 0 };
  int oneGroupType[XkbNumKbdGroups] = { XkbOneLevelIndex };

  if (XkbChangeTypesOfKey(xkb, keycode, 1, XkbGroup1Mask, oneGroupType, &changes)) {
    fprintf(stderr, "ERROR changing type of key\n");
    exit(1);
  }
  XkbKeySymEntry(xkb,keycode,0,0) = keysym;

  if (!XkbChangeMap(dpy,xkb,&changes)) {
    fprintf(stderr, "ERROR changing map\n");
    exit(1);
  }

  XkbFreeKeyboard (xkb, 0, TRUE);
  XFlush (dpy);
  XSync (dpy, False);

This had being going under the radar since about ever until commit
de940e06f8 ("xkb: fix key type index check
in _XkbSetMapChecks") fixed checking the values of kt_index, which was
previously erroneously ignoring errors and ignoring all other checks, just
because nTypes was not set, precisely because CheckKeyTypes was not called.

Note: yes, CheckKeyTypes is meant to be callable without XkbKeyTypesMask, it
does properly check for that and just fills nTypes and mapWidths in that
case.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
2022-02-03 21:44:37 +00:00
.gitlab-ci Update the CI to provide wayland-protocols 1.22 2021-12-07 10:02:29 +00:00
Xext Xext: Fix out of bounds access in SProcScreenSaverSuspend() 2021-12-14 15:00:02 +02:00
Xi Convert more funcs to use InternalEvent. 2021-12-19 20:01:04 +00:00
composite Remove autotools support 2021-10-27 13:15:40 +03:00
config Remove autotools support 2021-10-27 13:15:40 +03:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Remove autotools support 2021-10-27 13:15:40 +03:00
dix dix: Hold input lock for AttachDevice() 2022-02-03 16:56:53 +00:00
doc Remove autotools support 2021-10-27 13:15:40 +03:00
dri3 Remove autotools support 2021-10-27 13:15:40 +03:00
exa Remove autotools support 2021-10-27 13:15:40 +03:00
fb Remove autotools support 2021-10-27 13:15:40 +03:00
glamor glamor: fix free of uninitialised pointers 2021-12-03 20:54:46 +11:00
glx glx/dri: Filter out fbconfigs that don't have a supported pixmap format 2021-12-19 10:26:03 +00:00
hw xf86: Accept devices with the 'hyperv_drm' driver 2022-01-29 11:20:34 +00:00
include xf86/logind: Fix compilation error when built without logind/platform bus 2021-12-20 16:56:14 +01:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Remove autotools support 2021-10-27 13:15:40 +03:00
mi Remove autotools support 2021-10-27 13:15:40 +03:00
miext Remove autotools support 2021-10-27 13:15:40 +03:00
os Remove autotools support 2021-10-27 13:15:40 +03:00
present present: Check for NULL to prevent crash 2022-01-19 10:23:20 -08:00
pseudoramiX Remove autotools support 2021-10-27 13:15:40 +03:00
randr randr: add new interface to allow delaying lease responses 2021-12-07 10:02:29 +00:00
record record: Fix out of bounds access in SwapCreateRegister() 2021-12-14 15:00:00 +02:00
render render: Fix build with gcc 12 2022-01-25 16:16:30 +01:00
test test: #undef NDEBUG so assert is not compiled away 2021-12-08 20:59:21 +00:00
xfixes xfixes: Fix out of bounds access in *ProcXFixesCreatePointerBarrier() 2021-12-14 15:00:01 +02:00
xkb xkb: fix XkbSetMap when changing a keysym without changing a keytype 2022-02-03 21:44:37 +00:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml Update the CI to provide wayland-protocols 1.22 2021-12-07 10:02:29 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
meson.build require wayland-protocols 1.22 2021-12-07 10:02:29 +00:00
meson_options.txt Fix spelling of Xwayland 2021-12-17 16:22:07 +00:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct