XLibre Xserver
Go to file
Olivier Fourdan 2efa6d6595 dix: Fix overzealous caching of ResourceClientBits()
Commit c7311654 cached the value of ResourceClientBits(), but that value
depends on the `MaxClients` value set either from the command line or
from the configuration file.

For the latter, a call to ResourceClientBits() is issued before the
configuration file is read, meaning that the cached value is from the
default, not from the maximum number of clients set in the configuration
file.

That obviously causes all sort of issues, including memory corruption
and crashes of the Xserver when reaching the default limit value.

To avoid that issue, also keep the LimitClient value, and recompute the
ilog2() value if that changes, as on startup when the value is set from
the the xorg.conf ServerFlags section.

v2: Drop the `cache == 0` test
    Rename cache vars

Fixes: c7311654 - dix: cache ResourceClientBits() value
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1310
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
2022-07-27 17:09:29 +02:00
.gitlab-ci CI: Update gitlab CI to use debian bullseye 2022-07-01 21:38:54 +00:00
Xext Xext: the check firstValuator ≤ 1 is duplicated in this branch 2022-04-02 18:06:30 +00:00
Xi dix: Correctly save replayed event into GrabInfoRec 2022-02-09 11:33:03 +00:00
composite Remove autotools support 2021-10-27 13:15:40 +03:00
config fdi2iclass: remove unused local variable 2022-04-02 18:06:30 +00:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe Remove autotools support 2021-10-27 13:15:40 +03:00
dix dix: Fix overzealous caching of ResourceClientBits() 2022-07-27 17:09:29 +02:00
doc Remove autotools support 2021-10-27 13:15:40 +03:00
dri3 Remove autotools support 2021-10-27 13:15:40 +03:00
exa exa: fix "comparison is always false" 2022-04-02 18:06:30 +00:00
fb Remove autotools support 2021-10-27 13:15:40 +03:00
glamor glamor: fix free of uninitialised pointers 2021-12-03 20:54:46 +11:00
glx glx: remove a noop assert (index is unsigned) 2022-04-02 18:06:30 +00:00
hw xwayland: Fix "-force-xrandr-emulation" 2022-07-26 11:06:58 +02:00
include xkb: move the SProcXkbDispatch declaration 2022-07-08 14:27:04 +00:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Remove autotools support 2021-10-27 13:15:40 +03:00
mi Remove autotools support 2021-10-27 13:15:40 +03:00
miext rootless: Dead code removal (ROOTLESS_REDISPLAY_DELAY is already defined) 2022-06-13 22:01:04 -07:00
os meson: Use system method for locating tirpc 2022-07-01 21:38:54 +00:00
present present: Check for NULL to prevent crash 2022-01-19 10:23:20 -08:00
pseudoramiX Remove autotools support 2021-10-27 13:15:40 +03:00
randr randr: Add "RANDR Emulation" property 2022-04-20 10:03:15 +02:00
record record: Fix out of bounds access in SwapCreateRegister() 2021-12-14 15:00:00 +02:00
render render: Fix build with gcc 12 2022-01-25 16:16:30 +01:00
test xkb: rename xkb.h to xkb-procs.h 2022-07-08 14:27:04 +00:00
xfixes xfixes: Fix out of bounds access in *ProcXFixesCreatePointerBarrier() 2021-12-14 15:00:01 +02:00
xkb xkb: proof GetCountedString against request length attacks 2022-07-13 14:37:51 +10:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml CI: Update gitlab CI to use debian bullseye 2022-07-01 21:38:54 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
meson.build meson: Bump requirement to meson-0.52.0 2022-07-01 21:38:54 +00:00
meson_options.txt xwayland: add optional support for libdecor 2022-06-30 17:53:01 +02:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct