xserver

History

Alex Goins 456dff1bf8 modesetting: Fix msSharePixmapBacking Segfault Regression Commit `cb1b1e184` modified msSharePixmapBacking() to derive modesettingPtr from the 'screen' argument. Unfortunately, the name of the argument is misleading -- the screen is the slave screen. If the master is modesetting, and the slave is not modesetting, it will segfault. To fix the problem, this change derives modesettingPtr from ppix->drawable.pScreen. This method is already used when calling ms->glamor.shareable_fd_from_pixmap() later in the function. To avoid future issues, this change also renames the 'screen' argument to 'slave'. Signed-off-by: Alex Goins <agoins@nvidia.com> Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>	2019-12-23 08:56:22 -08:00
..
modesetting	modesetting: Fix msSharePixmapBacking Segfault Regression	2019-12-23 08:56:22 -08:00
Makefile.am	modesetting: Connect the driver to the build.	2014-09-16 16:28:42 -07:00

Alex Goins 456dff1bf8 modesetting: Fix msSharePixmapBacking Segfault Regression

Commit cb1b1e184 modified msSharePixmapBacking() to derive modesettingPtr from
the 'screen' argument. Unfortunately, the name of the argument is misleading --
the screen is the slave screen. If the master is modesetting,
and the slave is not modesetting, it will segfault.

To fix the problem, this change derives modesettingPtr from
ppix->drawable.pScreen. This method is already used when calling
ms->glamor.shareable_fd_from_pixmap() later in the function.

To avoid future issues, this change also renames the 'screen' argument to
'slave'.

Signed-off-by: Alex Goins <agoins@nvidia.com>
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>

2019-12-23 08:56:22 -08:00

modesetting modesetting: Fix msSharePixmapBacking Segfault Regression 2019-12-23 08:56:22 -08:00

Makefile.am modesetting: Connect the driver to the build. 2014-09-16 16:28:42 -07:00