xserver/hw
Jose Maria Casanova Crespo 4912f693e8 modesetting: Fix front_bo leak at drmmode_xf86crtc_resize on XRandR rotation
Since the introduction of "modesetting: Remove unnecessary fb addition from
drmmode_xf86crtc_resize" the fb_id isn't initialited at
drmmode_xf86crtc_resize.

Rotate operation of XRandR uses rotate_bo. So in this case the fb_id
associated to the front_bo is not initialized at drmmode_set_mode_major.
So fd_id remains 0.

As every call to drmmode_xf86crtc_resize allocates a new front_bo we should
destroy unconditionally the old_front_bo if operation success. So we free
the allocated GBM handles.

This avoids crashing xserver with a OOM in the RPI4 1Gb at 4k resolution
after 3 series xrandr rotations from normal to left and vice versa reported at
https://github.com/raspberrypi/firmware/issues/1345

Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1024
Fixes: 8774532121 "modesetting: Remove unnecessary fb addition from
       drmmode_xf86crtc_resize"
(cherry picked from commit 73480f172a)
2020-07-21 15:22:48 +00:00
..
dmx Fix building with `-fno-common` 2020-03-07 11:58:57 -08:00
kdrive Add ddxInputThread call from os layer into ddx layer 2020-01-13 22:25:39 +00:00
vfb Add ddxInputThread call from os layer into ddx layer 2020-01-13 22:25:39 +00:00
xfree86 modesetting: Fix front_bo leak at drmmode_xf86crtc_resize on XRandR rotation 2020-07-21 15:22:48 +00:00
xnest Add ddxInputThread call from os layer into ddx layer 2020-01-13 22:25:39 +00:00
xquartz glx,xquartz: Fix make distcheck 2019-02-25 13:06:58 -05:00
xwayland xwayland: Store xwl_tablet_pad in its own private key 2020-07-20 15:54:39 +02:00
xwin Add ddxInputThread call from os layer into ddx layer 2020-01-13 22:25:39 +00:00
Makefile.am Xwayland DDX 2014-04-03 15:19:22 -07:00
meson.build meson: Move Xvfb build under an option. 2017-09-20 13:19:21 -04:00