frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/hw/xquartz
History
Jamey Sharp 4b9600a416 Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 
This matches the test in TryClientEvents, and is a superset of tests
done by the callers of these functions. The consequence of forgetting
these tests is a server crash, so they're always desirable. In my
opinion, it's better to not require the callers to remember to do these
checks.

For callers that don't do very much work before calling WriteToClient or
WriteEventsToClient, I've removed the redundant checks.

hw/xquartz/xpr/appledri.c has an interesting case: While its check for
"client == NULL" appears redundant with the test in WriteEventsToClient,
it dereferences client to get the sequence number.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27497
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Adam Jackson <ajax@redhat.com>
 		2010-05-19 12:32:34 -07:00
..
GL Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
bundle XQuartz: add new localization files to EXTRA_DIST 2010-05-04 13:08:16 -07:00
doc XQuartz: Customize the NSDefaults id in the man file. 2010-04-11 16:30:22 -07:00
mach-startup XQuartz: Fix a build failure on Tiger 2010-05-16 13:12:31 -07:00
pbproxy XQuartz: pbproxy: Make standalone xpbproxy respect the launchd prefix 2010-03-21 21:56:39 -07:00
xpr Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
Makefile.am XQuartz: remove undefined XSERVER_CFLAGS variable 2010-03-15 08:24:02 -07:00
X11Application.h XQuartz: Add a defaults option to toggle Alt / Mode_switch 2010-04-11 16:30:19 -07:00
X11Application.m XQuartz: Don't use deltaXY for determining pointer location on scroll events 2010-05-16 13:12:26 -07:00
X11Controller.h XQuartz: Add a GUI preference for the Alt / Mode_switch toggle 2010-04-11 16:30:25 -07:00
X11Controller.m XQuartz: Add a defaults option to toggle Alt / Mode_switch 2010-04-11 16:30:19 -07:00
applewm.c Make WriteEventsToClient/WriteToClient no-op on fake or dead clients. 2010-05-19 12:32:34 -07:00
applewmExt.h XQuartz: ProcAppleWMAttachTransient to play nice with the new Dock in SL 2009-07-03 19:46:00 -07:00
darwin.c Replace X-allocation functions with their C89 counterparts 2010-05-13 00:22:37 +07:00
darwin.h XQuartz: Dead code removal 2010-01-30 14:30:40 -08:00
darwinEvents.c XQuartz: Fix a bunch of compilation warnings about style 2009-09-27 23:31:35 -07:00
darwinEvents.h XQuartz: Transition from xEvent based mieq to InternalEvent 2009-09-27 23:31:07 -07:00
darwinXinput.c XQuartz: Fix linking (CloseInput()) 2010-02-15 15:03:49 -08:00
darwinfb.h XQuartz: Unify how we set our bitmasks for visuals 2009-07-31 15:34:13 -07:00
keysym2ucs.c Darwin: Flattened quartz into darwin, renamed darwin xquartz 2007-12-05 20:32:40 -08:00
keysym2ucs.h Darwin: Flattened quartz into darwin, renamed darwin xquartz 2007-12-05 20:32:40 -08:00
pseudoramiX.c Eliminate boilerplate around client->noClientException. 2010-05-13 17:14:07 -07:00
pseudoramiX.h Darwin: Flattened quartz into darwin, renamed darwin xquartz 2007-12-05 20:32:40 -08:00
quartz.c scrnintstr.h: removed unused PaintWindow function pointers. 2010-05-14 08:27:10 +03:00
quartz.h XQuartz: Fix a bunch of compilation warnings about style 2009-09-27 23:31:35 -07:00
quartzAudio.c XQuartz: Fix a possible buffer overrun in quartzAudio 2010-02-15 16:46:21 -08:00
quartzAudio.h XQuartz: Purge redundant QuartzBell 2009-08-05 16:17:01 -07:00
quartzCocoa.m XQuartz: Transition from xEvent based mieq to InternalEvent 2009-09-27 23:31:07 -07:00
quartzCommon.h XQuartz: Add a defaults option to toggle Alt / Mode_switch 2010-04-11 16:30:19 -07:00
quartzKeyboard.c XQuartz: Add a defaults option to toggle Alt / Mode_switch 2010-04-11 16:30:19 -07:00
quartzKeyboard.h XQuartz: Add a defaults option to toggle Alt / Mode_switch 2010-04-11 16:30:19 -07:00
quartzStartup.c Xquartz: Removed include directive for removed header 2008-07-11 10:13:06 -07:00
sanitizedCarbon.h XQuartz: Handled sanitization of namespace better 2008-04-18 20:07:55 -07:00
sanitizedCocoa.h XQuartz: Handled sanitization of namespace better 2008-04-18 20:07:55 -07:00
threadSafety.c XQuartz: spewCallStack is noop on Tiger now... 2008-11-21 10:59:41 -08:00
threadSafety.h XQuartz: Cleaned up startup and thread creation a tad. 2008-04-26 19:21:05 -07:00