Simplifying the code flow allocating/checking/copying some buffers in RRConfigureOutputProperty() and RRConfigureProviderProperty() so it's easier to understand for both the human reader as well as the analyzer. Depending on whether we have elements to process, a temporary buffer needs to be allocated, checked for successful allocation and copy over data. The way it's currently done is technically correct, but unnecessarily complex to understand: instead of just branching on whether there are elements and doing all the buffer-related things only then, the branching is done just somewhere in the middle, only on checking for allocation failure, and relying on both calloc() and memcpy() not doing weird things when size is zero. It's easy to simplify by putting it all behind one if statement and so make things easier for both human reader as well as the analyzer (so it's not spilling out false alarms here anymore) and also drops unnecessary calls in the zero-size case. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> |
||
---|---|---|
.gitlab-ci | ||
Xext | ||
Xi | ||
composite | ||
config | ||
damageext | ||
dbe | ||
dix | ||
doc | ||
dri3 | ||
exa | ||
fb | ||
glamor | ||
glx | ||
hw | ||
include | ||
man | ||
mi | ||
miext | ||
os | ||
present | ||
pseudoramiX | ||
randr | ||
record | ||
render | ||
test | ||
xfixes | ||
xkb | ||
.appveyor.yml | ||
.dir-locals.el | ||
.git-blame-ignore-revs | ||
.gitignore | ||
.gitlab-ci.yml | ||
.mailmap | ||
.travis.yml | ||
COPYING | ||
README.md | ||
meson.build | ||
meson_options.txt | ||
xorg-server.m4 | ||
xorg-server.pc.in | ||
xserver.ent.in |
X Server
The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.
Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.
For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server
All questions regarding this software should be directed at the Xorg mailing list:
https://lists.freedesktop.org/mailman/listinfo/xorg
The primary development code repository can be found at:
https://gitlab.freedesktop.org/xorg/xserver
For patch submission instructions, see:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches
As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc: