XLibre Xserver
Go to file
Michel Dänzer 6b290fa5d9 xwayland: Replace window pixmap as needed for drawing operation
We must not modify the contents of a client pixmap.

If there's an available window buffer, we re-use that for the window
pixmap. Otherwise we just allocate a new one.

This also avoids Present client hangs due to xwl_present_buffer_release
not getting called for the buffer release event.

v2:
* Use xwl_pixmap_get_buffer_release_cb instead of keeping track of the
  flip pixmap in xwl_window.
* Dispose of xwl_window_buffer in xwl_window_swap_pixmap called from
  damage_report.
v3:
* Use xwl_window->surface_pixmap in damage_report.
v4:
* Don't re-use client pixmaps as window buffers.
* Clear xwl_window_buffer->pixmap before calling
  xwl_window_buffer_maybe_dispose in xwl_window_swap_pixmap, to prevent
  it from clearing the buffer release callback.
v5:
* Keep using xwl_window_buffers_get_pixmap in xwl_window_attach_buffer.
* Always keep a reference to the old window pixmap in _swap_pixmap,
  drop it in damage_report.

Fixes: 6779ec5bf6 ("xwayland: Use window pixmap as a window buffer")
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1633
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1644
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314>
2024-03-06 17:12:54 +01:00
.gitlab-ci drop remains of DMX 2024-03-05 16:57:52 +01:00
Xext drop remains of DMX 2024-03-05 16:57:52 +01:00
Xi Xi: drop duplicate _X_EXPORT from .c source 2024-03-03 22:34:26 +00:00
composite composite: move out unexported CompositeIsImplicitRedirectException() 2024-03-03 22:50:07 +00:00
config Fix build on OpenBSD. 2024-02-17 16:14:23 +01:00
damageext Remove autotools support 2021-10-27 13:15:40 +03:00
dbe dbe: drop obsolete NEED_DBE_PROTOCOL 2024-02-28 11:29:39 +01:00
dix drop remains of DMX 2024-03-05 16:57:52 +01:00
doc dix: dixutils: make workQueue pointer dix-private 2024-02-23 23:06:38 +00:00
dri3 randr: move private definitons from randrstr.h to randrstr_priv.h 2024-02-22 23:47:49 +00:00
exa render: move private definitions out of public glyphstr.h 2024-03-03 22:54:16 +00:00
fb render: move private definitions out of public glyphstr.h 2024-03-03 22:54:16 +00:00
glamor render: move private definitions out of public glyphstr.h 2024-03-03 22:54:16 +00:00
glx include: drop obsolete registry.h 2024-03-03 23:20:06 +00:00
hw xwayland: Replace window pixmap as needed for drawing operation 2024-03-06 17:12:54 +01:00
include drop remains of DMX 2024-03-05 16:57:52 +01:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man Disallow byte-swapped clients by default 2023-01-06 11:59:37 +10:00
mi drop remains of DMX 2024-03-05 16:57:52 +01:00
miext miext: move private definitions out of public headers 2024-03-03 22:58:24 +00:00
os os: drop unneeded DDXOSVERRORF conditional 2024-03-03 23:15:14 +00:00
present randr: move private definitons from randrstr.h to randrstr_priv.h 2024-02-22 23:47:49 +00:00
pseudoramiX Remove autotools support 2021-10-27 13:15:40 +03:00
randr render: drop obsolete macros pict_f_transform and pict_f_vector 2024-03-03 22:54:16 +00:00
record record: Support architectures with sizeof(void*) > sizeof(long) 2023-12-17 19:30:52 +00:00
render include: move xsha1.h to os/ 2024-03-03 23:11:05 +00:00
test xkb: drop defining XKBSRV_NEED_FILE_FUNCS 2024-02-19 00:44:15 +00:00
xfixes render: move private definitions out of picturestr.h 2024-03-03 22:54:16 +00:00
xkb xkb: drop duplicate _X_EXPORT from .c source 2024-03-03 22:34:26 +00:00
.appveyor.yml appveyor: Add libxcvt build dep 2021-11-04 13:03:25 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore Clean up the .gitignore file 2024-01-12 00:50:24 +00:00
.gitlab-ci.yml CI: replace the dist script with invocations of the meson-build script 2024-02-29 01:27:02 +00:00
.mailmap Add a .mailmap file to canonicalize author names and emails 2023-03-15 18:10:51 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
meson.build build: Xwayland with GLAMOR requires libxshmfence 2024-03-03 23:29:40 +00:00
meson_options.txt meson: add option for systemd_notify 2024-01-08 01:23:55 +00:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct