xserver/hw
Olivier Fourdan 8707d2835c xwayland: Do not keep the cursor's pixmap around
Currently, Xwayland creates a pixmap backed by shared memory buffer as
soon as an X11 cursor is realized, which is destroyed when the cursor is
eventually unrealized.

If an X11 client is leaking cursors, Xwayland will be creating new
pixmaps continuously, which will eventually cause an error once the
limit is reached, and get Xwayland killed.

However, we do not need the shared memory buffer to stay around, we
already have the buffer retention mechanism which will take care of
keeping the buffer around until the Wayland compositor is done with it,
so we could just create and destroy the pixmap as needed when setting
the cursor.

That would not fix the leak in the X11 application, yet that would
mitigate the risk of Xwayland being killed by reaching the shared memory
limits, until the client itself reaches the limit of X11 resources.

v2: Don't increase the pixmap refcnt to destroy it just after (Michel)

Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Suggested-by: Michel Dänzer <michel@daenzer.net>
See-also: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1773
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1754>
2024-12-20 09:29:03 +01:00
..
kdrive drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
vfb drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xfree86 hw/xfree86: Fix -Wincompatible-pointer-types sbus compile failure 2024-12-16 22:41:47 -05:00
xnest Xnest: drop obsolete ifdef HAVE_XNEST_CONFIG_H 2024-10-10 13:38:31 +00:00
xquartz xquartz: drop unused code 2024-10-10 16:42:38 +00:00
xwayland xwayland: Do not keep the cursor's pixmap around 2024-12-20 09:29:03 +01:00
xwin xwin: fix memleak on freeing pixmaps 2024-10-10 20:27:11 +00:00
meson.build Drop DMX DDX 2021-09-07 09:34:31 +00:00