frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
XLibre Xserver
17,304 Commits 293 Branches 13 Tags 61 MiB
C 96.4%
Roff 1.1%
Objective-C 1%
Meson 0.8%
Shell 0.2%
Other 0.3%
Go to file
Jose Maria Casanova Crespo 73480f172a modesetting: Fix front_bo leak at drmmode_xf86crtc_resize on XRandR rotation 
Since the introduction of "modesetting: Remove unnecessary fb addition from
drmmode_xf86crtc_resize" the fb_id isn't initialited at
drmmode_xf86crtc_resize.

Rotate operation of XRandR uses rotate_bo. So in this case the fb_id
associated to the front_bo is not initialized at drmmode_set_mode_major.
So fd_id remains 0.

As every call to drmmode_xf86crtc_resize allocates a new front_bo we should
destroy unconditionally the old_front_bo if operation success. So we free
the allocated GBM handles.

This avoids crashing xserver with a OOM in the RPI4 1Gb at 4k resolution
after 3 series xrandr rotations from normal to left and vice versa reported at
https://github.com/raspberrypi/firmware/issues/1345

Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1024
Fixes: 8774532121 "modesetting: Remove unnecessary fb addition from
       drmmode_xf86crtc_resize"
 		2020-06-27 08:29:45 +00:00
.gitlab-ci gitlab-ci: Install libnvidia-egl-wayland-dev package 2020-01-06 15:52:33 +01:00
Xext os: Don't crash in AttendClient if the client is gone 2019-11-19 10:15:05 -08:00
Xi xinput: Remove PropagateMask 2020-03-30 21:48:11 +00:00
composite composite: Stop wrapping GetImage/GetSpans 2019-10-30 16:26:01 +00:00
config udev: Fixed NULL pointer argument of strcmp 2019-09-20 05:33:47 +00:00
damageext Use ARRAY_SIZE all over the tree 2017-10-30 13:45:20 -04:00
dbe meson: Distribute more SDK headers 2018-04-02 13:42:08 -04:00
dix os: Don't crash in AttendClient if the client is gone 2019-11-19 10:15:05 -08:00
doc mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
dri3 dri3: Fix XACE access mode for open and get_supported_modifiers 2019-01-16 20:05:43 +00:00
exa Fix build with gcc 9.3.0's -Werror=alloc-size-larger-than= 2020-05-01 20:02:29 +00:00
fb fboverlay: move bpp checks above malloc 2018-09-12 12:26:48 +10:00
glamor glamor_egl: Reject OpenGL < 2.1 early on 2020-01-08 15:20:10 +00:00
glx glx: unbreak on Unix without /usr/include/drm 2020-05-27 07:15:07 +00:00
hw modesetting: Fix front_bo leak at drmmode_xf86crtc_resize on XRandR rotation 2020-06-27 08:29:45 +00:00
include meson: split udev from udev_kms which requires systemd 2020-05-27 07:16:02 +00:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man dix: Remove -to option to set the default connection timeout 2019-10-30 16:17:04 +00:00
mi misprite: Stop wrapping GetImage/GetSpans 2019-10-30 16:26:01 +00:00
miext mi: Add a default no-op miSourceValidate 2019-10-30 16:26:01 +00:00
os os: unbreak xsha1 on FreeBSD 2020-05-27 07:15:07 +00:00
present present/wnmd: Free flip_queue entries in present_wnmd_clear_window_flip 2020-06-25 17:27:10 +02:00
pseudoramiX Unvalidated lengths 2017-10-10 23:33:34 +02:00
randr Fix build with gcc 9.3.0's -Werror=alloc-size-larger-than= 2020-05-01 20:02:29 +00:00
record os: Don't crash in AttendClient if the client is gone 2019-11-19 10:15:05 -08:00
render dix: Call SourceValidate before GetImage 2019-10-30 16:26:01 +00:00
test test: Fix struct initialization warning 2020-05-08 16:45:50 +02:00
xfixes xfixes: Restore monitoring of animated cursors 2018-02-14 13:52:45 -05:00
xkb xkb: fix key type index check in _XkbSetMapChecks 2020-02-25 12:12:55 -05:00
.appveyor.yml hw/xwin: Remove XSetAuthorization() for helper clients 2020-04-15 14:13:58 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml gitlab CI: use the fdo ci-templates repository 2020-05-20 11:01:13 +10:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
Makefile.am xfree86: Merge vbe into int10 2019-10-02 10:03:26 -04:00
README.md Update README for gitlab migration 2018-11-25 20:55:11 +00:00
autogen.sh autogen: Set a default subject prefix for patches 2016-02-08 17:41:38 -05:00
configure.ac Remove BSD APM support. 2020-06-03 17:33:10 +02:00
devbook.am doc: Create a script to filter xmlto output 2015-01-05 14:24:06 -08:00
docbook.am docbook.am: embed css styles inside the HTML HEAD element 2011-09-21 14:07:49 -07:00
manpages.am man: Fix automake seddery 2018-05-08 12:15:30 -04:00
meson.build meson: split udev from udev_kms which requires systemd 2020-05-27 07:16:02 +00:00
meson_options.txt meson: split udev from udev_kms which requires systemd 2020-05-27 07:16:02 +00:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

README.md

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The master development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct