frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/Xi
History
dec05eba 2f66431927 xi: Fix build on arch linux (cast between struct and union gcc error) 
Fixes this build error on arch linux:

../Xi/exevents.c:1394:26: error: array subscript ‘InternalEvent {aka union _InternalEvent}[0]’ is partly outside array bounds of ‘DeviceEvent[1]’ {aka ‘struct _DeviceEvent[1]’} [-Werror=array-bounds=]
 1394 |                 evtype = GetXI2Type(ev->any.type);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~
../Xi/exevents.c: In function ‘DeliverEmulatedMotionEvent’:
../Xi/exevents.c:1571:17: note: object ‘motion’ of size 432
 1571 |     DeviceEvent motion;
      |

which happens because of change in build options compared to master and gcc 15.1 in arch. I think this warning (and error) is a bug in gcc.

gcc 15.1 doesn't like when struct DeviceEvent is cast to union InternalEvent.
InternalEvent has a union any type and DeviceEvent type and these have to have a matching structure (for the header part).
When the InternalEvent is used in RetrieveTouchDeliveryData function it access the any field, which accessed the data defined previously in the device_event fields.
This change matches how its done in touch.c TouchEmitTouchEnd for example and it's "more correct",
since we are no longer casting from a smaller struct (DeviceEvent) to a larger struct (InternalEvent) when calling RetrieveTouchDeliveryData.

Signed-off-by: dec05eba <dec05eba@protonmail.com>
 		2025-06-13 19:08:17 +02:00
..
XIstubs.h include: unexport XIstubs.h 2024-09-01 22:21:12 +00:00
allowev.c include: drop obsolete dixevents.h 2025-06-12 16:17:35 +02:00
allowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgdctl.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
chgdctl.h XI: directly write out X_ChangeDeviceControl reply 2025-06-12 17:21:43 +02:00
chgfctl.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
chgfctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgkbd.c Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
chgkbd.h Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
chgkmap.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
chgkmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgprop.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
chgprop.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgptr.c include: drop obsolete dixevents.h 2025-06-12 16:17:35 +02:00
chgptr.h Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
closedev.c dix: make SameClient() macro private 2025-06-12 16:53:43 +02:00
closedev.h Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
devbell.c Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
devbell.h Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
exevents.c xi: Fix build on arch linux (cast between struct and union gcc error) 2025-06-13 19:08:17 +02:00
exglobals.h Xi: use fixed define for extenion base opcode 2025-06-12 17:21:43 +02:00
extinit.c Xi: unexport AssignTypeAndName() 2025-06-12 17:21:46 +02:00
getbmap.c XI: directly write out X_GetDeviceButtonMapping reply 2025-06-12 17:21:43 +02:00
getbmap.h XI: directly write out X_GetDeviceButtonMapping reply 2025-06-12 17:21:43 +02:00
getdctl.c XI: directly write out X_GetDeviceControl reply 2025-06-12 17:21:43 +02:00
getdctl.h XI: directly write out X_GetDeviceControl reply 2025-06-12 17:21:43 +02:00
getfctl.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getfctl.h XI: directly write out X_GetFeedbackControl reply 2025-06-12 17:21:43 +02:00
getfocus.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getfocus.h XI: directly write out X_GetDeviceFocus reply 2025-06-12 17:21:43 +02:00
getkmap.c XI: directly write out X_GetDeviceKeyMapping reply 2025-06-12 17:21:43 +02:00
getkmap.h XI: directly write out X_GetDeviceKeyMapping reply 2025-06-12 17:21:43 +02:00
getmmap.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getmmap.h XI: directly write out X_GetDeviceModifierMapping reply 2025-06-12 17:21:43 +02:00
getprop.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getprop.h XI: directly write out X_GetDeviceDontPropagateList reply 2025-06-12 17:21:42 +02:00
getselev.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getselev.h XI: directly write out X_GetSelectedExtensionEvents reply 2025-06-12 17:21:42 +02:00
getvers.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
getvers.h XI: directly write out X_GetExtensionVersion reply 2025-06-12 17:21:42 +02:00
grabdev.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
grabdev.h XI: directly write out X_GrabDevice reply 2025-06-12 17:21:43 +02:00
grabdevb.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
grabdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdevk.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
grabdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
gtmotion.c XI: directly write out X_GetDeviceMotionEvents reply 2025-06-12 17:21:43 +02:00
gtmotion.h XI: directly write out X_GetDeviceMotionEvents reply 2025-06-12 17:21:43 +02:00
listdev.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
listdev.h XI: directly write out X_ListInputDevices reply 2025-06-12 17:21:42 +02:00
meson.build Add a Meson build system alongside autotools. 2017-04-26 15:25:27 -07:00
opendev.c XI: directly write out X_OpenDevice reply 2025-06-12 17:21:42 +02:00
opendev.h XI: directly write out X_OpenDevice reply 2025-06-12 17:21:42 +02:00
queryst.c XI: directly write out X_QueryDeviceState reply 2025-06-12 17:21:43 +02:00
queryst.h XI: directly write out X_QueryDeviceState reply 2025-06-12 17:21:43 +02:00
selectev.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
selectev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
sendexev.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
sendexev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setbmap.c XI: directly write out X_SetDeviceButtonMapping reply 2025-06-12 17:21:43 +02:00
setbmap.h XI: directly write out X_SetDeviceButtonMapping reply 2025-06-12 17:21:43 +02:00
setdval.c XI: directly write out X_SetDeviceValuators reply 2025-06-12 17:21:43 +02:00
setdval.h XI: directly write out X_SetDeviceValuators reply 2025-06-12 17:21:43 +02:00
setfocus.c include: drop obsolete dixevents.h 2025-06-12 16:17:35 +02:00
setfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setmmap.c XI: directly write out X_SetDeviceModifierMapping reply 2025-06-12 17:21:43 +02:00
setmmap.h XI: directly write out X_SetDeviceModifierMapping reply 2025-06-12 17:21:43 +02:00
setmode.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
setmode.h XI: directly write out X_SetDeviceMode reply 2025-06-12 17:21:42 +02:00
stubs.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
ungrdev.c dix: make SameClient() macro private 2025-06-12 16:53:43 +02:00
ungrdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevb.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
ungrdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevk.c Xi: drop swapping request length fields 2025-02-06 22:28:51 +00:00
ungrdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiallowev.c dix: rename IsMaster to InputDevIsMaster() 2025-06-12 16:19:33 +02:00
xiallowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xibarriers.c dix: replace CLIENT_ID() macro by dixClientIdForXID() inline function 2025-06-12 16:53:27 +02:00
xibarriers.h Xi: unexport PointerBarrierType field 2025-06-12 16:50:57 +02:00
xichangecursor.c dix: rename IsMaster to InputDevIsMaster() 2025-06-12 16:19:33 +02:00
xichangecursor.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xichangehierarchy.c Xi: use fixed define for extenion base opcode 2025-06-12 17:21:43 +02:00
xichangehierarchy.h Xi: drop now obsolete swap procs 2025-02-06 22:28:52 +00:00
xigetclientpointer.c treewide: clean up remaining consumers of extinit.h 2025-06-12 17:21:46 +02:00
xigetclientpointer.h XI: directly write out X_XIGetClientPointer reply 2025-06-12 17:21:43 +02:00
xigrabdev.c XI: directly write out X_XIGrabDevice reply 2025-06-12 17:21:43 +02:00
xigrabdev.h XI: directly write out X_XIGrabDevice reply 2025-06-12 17:21:43 +02:00
xipassivegrab.c XI: directly write out X_XIPassiveGrabDevice reply 2025-06-12 17:21:43 +02:00
xipassivegrab.h XI: directly write out X_XIPassiveGrabDevice reply 2025-06-12 17:21:43 +02:00
xiproperty.c xi: replace xallocarray() by calloc() 2025-06-12 17:21:43 +02:00
xiproperty.h XI: directly write out X_XIGetProperty reply 2025-06-12 17:21:43 +02:00
xiquerydevice.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
xiquerydevice.h XI: directly write out X_XIQueryDevice reply 2025-06-12 17:21:43 +02:00
xiquerypointer.c Xi: clean up including panoramix headers 2025-06-12 17:21:43 +02:00
xiquerypointer.h XI: directly write out X_XIQueryPointer reply 2025-06-12 17:21:43 +02:00
xiqueryversion.c XI: directly write out X_XIQueryVersion reply 2025-06-12 17:21:43 +02:00
xiqueryversion.h XI: directly write out X_XIQueryVersion reply 2025-06-12 17:21:43 +02:00
xiselectev.c Xi: allow hooks to silently ignore SelectEvents request 2025-06-12 17:21:48 +02:00
xiselectev.h XI: directly write out X_XIGetSelectedEvents reply 2025-06-12 17:21:43 +02:00
xisetclientpointer.c dix: rename dixLookupClient() to dixLookupResourceOwner() 2025-06-12 16:52:07 +02:00
xisetclientpointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xisetdevfocus.c Xi: use static reply struct init on declaration 2025-06-12 17:21:44 +02:00
xisetdevfocus.h XI: directly write out X_XIGetFocus reply 2025-06-12 17:21:43 +02:00
xiwarppointer.c dix: protect from pScreen->SetCursorPosition == NULL 2025-06-12 16:34:14 +02:00
xiwarppointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00