frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/Xi
History
Alan Coopersmith 284ad8e473 Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 
The comments in that function say "This only happens if master is a
slave device. don't do that" but static analysis doesn't respect that.

Found by Oracle Parfait 13.3:
   Null pointer dereference [null-pointer-deref]:
      Read from null pointer XTestptr
        at line 274 of Xi/xichangehierarchy.c in function 'remove_master'.
          Null pointer introduced at line 691 of Xext/xtest.c in function
	   'GetXTestDevice'.
          Function GetXTestDevice may return constant 'NULL' at line 691,
	   called at line 273 of Xi/xichangehierarchy.c in function
	   'remove_master'.
   Null pointer dereference [null-pointer-deref]:
      Read from null pointer XTestkeybd
        at line 279 of Xi/xichangehierarchy.c in function 'remove_master'.
          Null pointer introduced at line 691 of Xext/xtest.c in function
	   'GetXTestDevice'.
          Function GetXTestDevice may return constant 'NULL' at line 691,
	   called at line 278 of Xi/xichangehierarchy.c in function
	   'remove_master'.

Fixes: 0814f511d ("input: store the master device's ID in the devPrivate for XTest devices.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1730>
 		2024-10-31 16:24:41 +01:00
..
XIstubs.h include: unexport XIstubs.h 2024-09-01 22:21:12 +00:00
allowev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
allowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgdctl.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgdctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgfctl.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgfctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgkbd.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgkbd.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
chgkmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgkmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgprop.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgprop.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgptr.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
chgptr.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
closedev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
closedev.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
devbell.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
devbell.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
exevents.c (!1688) os: unexport internal logging functions 2024-09-18 17:23:12 +02:00
exglobals.h xinput: Remove PropagateMask 2020-03-30 21:48:11 +00:00
extinit.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getbmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getbmap.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
getdctl.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getdctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getfctl.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getfctl.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
getfocus.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getfocus.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
getkmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getkmap.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
getmmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getmmap.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
getprop.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getprop.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getselev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getselev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getvers.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
getvers.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
grabdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdevb.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
grabdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdevk.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
grabdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
gtmotion.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
gtmotion.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
listdev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
listdev.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
meson.build Add a Meson build system alongside autotools. 2017-04-26 15:25:27 -07:00
opendev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
opendev.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
queryst.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
queryst.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
selectev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
selectev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
sendexev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
sendexev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setbmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
setbmap.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
setdval.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
setdval.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
setfocus.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
setfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setmmap.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
setmmap.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
setmode.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
setmode.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
stubs.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
ungrdev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
ungrdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevb.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
ungrdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevk.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
ungrdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiallowev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiallowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xibarriers.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xibarriers.h Xi: free barrier code at reset time 2013-05-07 09:41:19 +10:00
xichangecursor.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xichangecursor.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xichangehierarchy.c Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 2024-10-31 16:24:41 +01:00
xichangehierarchy.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
xigetclientpointer.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xigetclientpointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xigrabdev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xigrabdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xipassivegrab.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xipassivegrab.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiproperty.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiproperty.h (!1639) Xi: drop now obsolete swap procs 2024-09-18 17:23:10 +02:00
xiquerydevice.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiquerydevice.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiquerypointer.c (submit/rename-panoramix-sym) rename old symbol PANORAMIX to XINERAMA 2024-09-18 17:23:12 +02:00
xiquerypointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiqueryversion.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiqueryversion.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiselectev.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiselectev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xisetclientpointer.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xisetclientpointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xisetdevfocus.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xisetdevfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiwarppointer.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xiwarppointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00