frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/os
History
Olivier Fourdan dfd1da4bbc os: Fix NULL pointer dereference 
RemoveHost() can be called from DisableLocalHost() with a NULL client,
but doesn't actually check whether the given client pointer is valid on
error and assigns the error value unconditionally, leading to a possible
NULL pointer dereference and a crash of the Xserver.

To avoid the issue, simply check whether the client pointer is not NULL
prior to assign the errorValue.

Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1752
See-also: https://bugzilla.redhat.com/2313799
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1701>
 		2024-10-31 15:44:45 +01:00
..
.gitignore dix and os: gitignore dix.O and os.O 2011-09-23 17:14:47 -07:00
WaitFor.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
access.c os: Fix NULL pointer dereference 2024-10-31 15:44:45 +01:00
alloc.c os: move alloc functions to separate source file 2024-02-29 10:09:37 +00:00
audit.h os: unexport audit functions 2024-04-15 19:54:34 +00:00
auth.c os: replace GenerateRandomData() by custom arc4random_buf() on platforms that missing it 2024-09-19 15:03:01 +02:00
auth.h os: unexport fields from opaque.h not used by modules / drivers 2024-06-23 21:19:27 +00:00
backtrace.c (!1691) os: log: replace ErrorFSigSafe() by ErrorF() 2024-09-19 15:03:01 +02:00
busfault.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
busfault.h os: fix missing include of misc.h in busfault.h 2024-04-16 14:19:59 +02:00
client.c Return NULL in *cmdname if the client argv or argv[0] is NULL 2024-10-31 15:43:35 +01:00
client_priv.h (!1279) os: don't include client.h anymore 2024-09-18 17:23:11 +02:00
cmdline.c (!1688) os: helper for parsing an counting-flag or value-flag option 2024-09-18 17:23:12 +02:00
cmdline.h (!1688) os: helper for parsing an counting-flag or value-flag option 2024-09-18 17:23:12 +02:00
connection.c (!1688) os: unexport internal logging functions 2024-09-18 17:23:12 +02:00
ddx_priv.h os: unexport ddx callbacks 2024-05-08 09:37:35 +02:00
fmt.c os: move out Format*() functions 2024-03-09 17:34:51 +00:00
fmt.h os: move out Format*() functions 2024-03-09 17:34:51 +00:00
inputthread.c (!1688) os: unexport internal logging functions 2024-09-18 17:23:12 +02:00
io.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
log.c (!1691) os: log: replace VErrorF() by LogVMessageVerb() 2024-09-19 15:03:01 +02:00
log_priv.h (!1688) os: log: add syslog support 2024-09-18 17:23:12 +02:00
meson.build (!1688) os: log: add syslog support 2024-09-18 17:23:12 +02:00
mitauth.c os: replace GenerateRandomData() by custom arc4random_buf() on platforms that missing it 2024-09-19 15:03:01 +02:00
mitauth.h os: move Auth* function types to separate header 2024-02-22 23:42:53 +00:00
osdep.h os: replace GenerateRandomData() by custom arc4random_buf() on platforms that missing it 2024-09-19 15:03:01 +02:00
osinit.c (!1691) os: log: replace ErrorFSigSafe() by ErrorF() 2024-09-19 15:03:01 +02:00
ospoll.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
ospoll.h os: Add ospoll interface [v2] 2016-07-21 15:04:47 -04:00
reallocarray.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
screensaver.h os: unexport screen saver timer functions 2024-09-01 20:23:10 +00:00
serverlock.c os: move -nolock help message printing to serverlock.h 2024-07-26 22:26:07 +00:00
serverlock.h os: move -nolock help message printing to serverlock.h 2024-07-26 22:26:07 +00:00
strcasecmp.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
strcasestr.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
string.c os: move string functions to separate source file 2024-02-29 10:09:37 +00:00
strlcat.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
strlcpy.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
strndup.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
timingsafe_memcmp.c timingsafe_memcmp: Fix meson build 2017-05-10 10:56:16 -04:00
utils.c (!1688) os: log: add syslog support 2024-09-18 17:23:12 +02:00
xdmauth.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xdmauth.h os: move Auth* function types to separate header 2024-02-22 23:42:53 +00:00
xdmcp.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xdmcp.h Fix build with -Dxdmcp=false 2024-02-25 11:55:56 +01:00
xprintf.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xserver_poll.c (submit/drop-cygwin) drop remains of cygwin support 2024-09-18 17:23:12 +02:00
xserver_poll.h os: move xserver_poll.h into os/ directory 2024-06-21 00:53:39 +00:00
xsha1.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00
xsha1.h include: move xsha1.h to os/ 2024-03-03 23:11:05 +00:00
xstrans.c (submit/drop-obsolete-have-dix-config.h) drop obsolete HAVE_DIX_CONFIG_H 2024-09-18 17:23:11 +02:00