frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/hw/xfree86/common
History
Alan Coopersmith b2bc38e4a5 Even more correctly free config file names 
If we didn't go into the if (!autoconfig) { } block, the filename,
dirname, and sysdirname pointers were never initialized, but we
freed them outside the block, leading to potential memory corruption.

Move the frees inside the block where they're initialized to avoid this.

To avoid similar problems, move the declarations of the variables that
are only used in this block inside the block.

Regression introduced by commit 3d635fe84d

Found by gcc warning:
xf86Config.c: In function 'xf86HandleConfigFile':
xf86Config.c:2303:11: warning: 'filename' may be used uninitialized in this function
xf86Config.c:2303:22: warning: 'dirname' may be used uninitialized in this function
xf86Config.c:2303:32: warning: 'sysdirname' may be used uninitialized in this function

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
 		2011-12-12 16:50:25 -08:00
..
.gitignore .gitignore: use common defaults with custom section #24239 2009-11-11 21:40:20 -08:00
Makefile.am Move DoShowOptions to xf86Configure.c, delete xf86ShowOpts.c 2011-11-23 12:15:06 -08:00
compiler.h Remove SCO support 2010-12-20 12:11:11 -05:00
extramodes Remove some default modes that really shouldn't be in the default set. 2008-06-24 10:40:36 -04:00
fourcc.h
…
modeline2c.awk Remove some OS/2 leftovers. 2009-04-06 10:58:47 -04:00
vesamodes Fix standard VESA modes. 2006-11-03 14:06:32 -08:00
vidmodeproc.h Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
xf86.h Remove xf86FormatPciBusNumber from API, inline the one place its used 2011-11-23 12:15:06 -08:00
xf86AutoConfig.c Don't fallback to wsfb or fbdev on Solaris 2011-11-23 12:15:04 -08:00
xf86Build.h.in Print the build time as well as the date if we can. 2007-06-04 02:03:44 -04:00
xf86Bus.c configure: wrap PCI code with macro and set it at build time 2011-10-15 21:18:47 -07:00
xf86Bus.h pci: Port xf86MapLegacyIO to pciaccess 2011-10-15 21:18:46 -07:00
xf86Config.c Even more correctly free config file names 2011-12-12 16:50:25 -08:00
xf86Config.h Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Configure.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Cursor.c Store desktop dimensions in screenInfo. 2011-10-13 11:26:09 +10:00
xf86DGA.c input: replace remaining GetPairedDevice() with GetMaster() 2011-11-09 13:26:47 +10:00
xf86DPMS.c configure: wrap PCI code with macro and set it at build time 2011-10-15 21:18:47 -07:00
xf86Events.c Fix drain_console unregistration 2011-10-18 09:15:54 +10:00
xf86Globals.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Helper.c xf86RegisterRootWindowProperty is confused about xnfcalloc 2011-12-10 11:51:03 -08:00
xf86InPriv.h xfree86: make xf86ActivateDevice static. 2010-09-01 15:26:47 +10:00
xf86Init.c xfree86: duplicate name and driver from pInfo for NewInputDeviceRequest 2011-11-04 07:46:58 +10:00
xf86Mode.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Module.h xfree86: bump the input ABI 2011-12-09 14:56:23 +10:00
xf86Opt.h Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Option.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Optionstr.h input: switch InputOption to use XF86OptionRec storage. 2011-10-25 14:06:39 +10:00
xf86PM.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86PciInfo.h xfree86: Deprecate the use of xf86PciInfo.h 2011-11-18 11:26:02 -08:00
xf86Priv.h Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86Privstr.h Remove unused vtSysreq 2011-09-29 23:05:35 +06:00
xf86RandR.c Store desktop dimensions in screenInfo. 2011-10-13 11:26:09 +10:00
xf86VGAarbiter.c configure: change PCI function checking by a meaningful version of the library 2011-10-15 21:18:47 -07:00
xf86VGAarbiter.h xfree86: vgaarb: fix device decoding interface to send resources type properly 2010-08-26 18:17:12 +03:00
xf86VGAarbiterPriv.h Revert "dix: Remove usage_hint from pixmaps, store it in ->drawable.class" 2011-03-17 23:48:52 -07:00
xf86VidMode.c VidMode: prevent crash with no modes 2011-11-18 11:26:02 -08:00
xf86Xinput.c Convert strncpy/strncat to strlcpy/strlcat 2011-11-23 12:15:05 -08:00
xf86Xinput.h xfree86: remove xf86XInputSetScreen 2011-10-13 11:07:50 +10:00
xf86cmap.c Unwrap/rewrap EnterVT/LeaveVT completely, Fixes 28998 2010-07-13 09:58:04 -07:00
xf86cmap.h Change the devPrivates API to require dixRegisterPrivateKey 2010-06-05 19:23:03 -07:00
xf86fbBus.c configure: wrap PCI code with macro and set it at build time 2011-10-15 21:18:47 -07:00
xf86fbman.c Change the devPrivates API to require dixRegisterPrivateKey 2010-06-05 19:23:03 -07:00
xf86fbman.h Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
xf86noBus.c xserver: remove RAC/resource handling code. 2009-07-28 15:14:28 +10:00
xf86pciBus.c Fix gcc -Wwrite-strings warnings in xf86 ddx 2011-11-23 12:15:07 -08:00
xf86pciBus.h xfree86: configure: move buses references to their own location 2010-09-14 18:51:59 +03:00
xf86sbusBus.c Convert a bunch of sprintf to snprintf calls 2011-11-23 12:15:06 -08:00
xf86sbusBus.h xfree86: configure: move buses references to their own location 2010-09-14 18:51:59 +03:00
xf86str.h configure: wrap PCI code with macro and set it at build time 2011-10-15 21:18:47 -07:00
xf86xv.c xfree86: xv: set pointers to NULL in xf86XVFreeAdaptor 2011-04-07 19:57:08 +03:00
xf86xv.h xf86/xv: Fill color key on expose 2011-02-03 14:38:10 +02:00
xf86xvmc.c Change the devPrivates API to require dixRegisterPrivateKey 2010-06-05 19:23:03 -07:00
xf86xvmc.h Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
xf86xvpriv.h xf86/xv: Use PostValidateTree to do reput 2011-02-03 14:38:36 +02:00
xisb.c Remove unnecessary parentheses around return values in functions 2010-06-10 06:42:42 -07:00
xisb.h Rework symbol visibility for easier maintenance 2008-12-03 05:43:34 -02:00
xorgHelper.c xfree86: ANSI cleanups 2009-01-11 08:54:11 +01:00
xorgVersion.h
…