XLibre Xserver
Go to file
Aaron Plattner b75d0cca28 modesetting: Defer crtc gamma size upgrade to drmmode_setup_colormap
Rather than trying to create a gamma ramp array of the appropriate size in
drmmode_crtc_init when the GAMMA_LUT property should be used, just flag the crtc
as wanting to use the GAMMA_LUT property and then replace the gamma ramp later,
right before calling xf86HandleColormaps. This avoids a problem during initial
startup where xf86RandR12CreateObjects12 hard-codes a gamma ramp size of 256,
causing xf86RandR12CrtcSetGamma to read past the end of the DIX layer's RandR
gamma ramp array:

  PreInit
    drmmode_pre_init
      drmmode_crtc_init
        crtc->gamma_size = 1024

  ScreenInit
    xf86CrtcScreenInit
      xf86RandR12Init
        xf86RandR12Init12
          xf86RandR12CreateObjects12
            RRCrtcCreate
              randr_crtc->gammaSize = 0
          xf86RandR12InitGamma(pScrn, 256)
            RRCrtcGammaSetSize
              randr_crtc->gammaSize = 256
          xf86RandR12InitGamma
            xf86RandR12CrtcInitGamma
              RRCrtcGammaSet
                xf86RandR12CrtcSetGamma
                  // crtc->gamma_size is 1024 here, while randr_crtc->gammaRed
                  // is a 256-element array.
                  memcpy(crtc->gamma_red, randr_crtc->gammaRed, crtc->gamma_size * sizeof(crtc->gamma_red[0]));
    drmmode_setup_colormap
      xf86HandleColormaps
        xf86RandR12InitGamma
          RRCrtcGammaSetSize
            randr_crtc->gammaSize = 1024

Fixes: 245b9db0 - modesetting: Use GAMMA_LUT when available
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1126
Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Robert Morell <rmorell@nvidia.com>
2021-04-05 14:25:33 -07:00
.gitlab-ci ci: Test ninja dist in meson jobs 2021-01-22 17:03:16 +00:00
Xext meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
Xi Xi: Deliver pointer emulated touch events to grabbing client 2021-02-15 04:40:16 +00:00
composite meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
config linux: Fix udev ID_PATH parsing for udl devices 2020-11-25 04:39:14 +00:00
damageext Use ARRAY_SIZE all over the tree 2017-10-30 13:45:20 -04:00
dbe meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
dix dix: Fix URL to description of focus in/out model 2021-03-25 23:18:14 +02:00
doc doc: Update URLs in Xserver-DTrace.xml 2020-07-05 13:18:45 -07:00
dri3 meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
exa exa: rename some badly named variables 2020-07-10 06:17:40 +10:00
fb meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
glamor glamor: Update pixmap's devKind when making it exportable 2020-11-04 10:21:11 -08:00
glx meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
hw modesetting: Defer crtc gamma size upgrade to drmmode_setup_colormap 2021-04-05 14:25:33 -07:00
include meson: Make sure XKM_OUTPUT_DIR has a trailing slash 2021-03-15 16:53:46 +01:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man dix: Remove -to option to set the default connection timeout 2019-10-30 16:17:04 +00:00
mi meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
miext miext: Remove if check which is always true 2021-03-26 09:02:14 +00:00
os xserver/os: safer IPv6 "kame hack" fix, only override sin6_scope_id if zero 2021-04-04 21:06:35 +00:00
present meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
pseudoramiX Unvalidated lengths 2017-10-10 23:33:34 +02:00
randr meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
record Fix XRecordRegisterClients() Integer underflow 2020-08-25 17:01:29 +02:00
render meson: hide C API if Xorg is disabled (like autotools) 2021-03-11 00:22:36 +00:00
test mi: List extensions in usage message 2021-01-29 12:52:09 +00:00
xfixes Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
xkb xkb: Fix parsing of XkbSA_DeviceValuator action type 2021-03-30 18:47:04 +00:00
.appveyor.yml hw/xwin: Remove XSetAuthorization() for helper clients 2020-04-15 14:13:58 +00:00
.dir-locals.el .dir-locals.el: Add missing final newline 2019-10-01 17:05:28 +00:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml ci: Test ninja dist in meson jobs 2021-01-22 17:03:16 +00:00
.travis.yml travis: Add OSX meson build to matrix 2019-05-02 15:42:58 +00:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
Makefile.am xfree86: Merge vbe into int10 2019-10-02 10:03:26 -04:00
README.md Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
autogen.sh autogen: Set a default subject prefix for patches 2016-02-08 17:41:38 -05:00
configure.ac xwayland: remove wl_log_set_handler_client workaround 2021-03-24 08:13:11 +01:00
devbook.am doc: Create a script to filter xmlto output 2015-01-05 14:24:06 -08:00
docbook.am docbook.am: embed css styles inside the HTML HEAD element 2011-09-21 14:07:49 -07:00
manpages.am man: Fix automake seddery 2018-05-08 12:15:30 -04:00
meson.build meson: Bump min meson version to 0.47 to get install_mode support 2021-03-26 09:18:55 +00:00
meson_options.txt xfree86: Implement a test input driver 2020-12-14 01:12:10 +00:00
xorg-server.m4 xorg-server.m4: just all cflags instead of just sdkdir 2018-09-20 20:12:24 +01:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The primary development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct