frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/Xi
History
Alan Coopersmith d10589cc09 Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 
The comments in that function say "This only happens if master is a
slave device. don't do that" but static analysis doesn't respect that.

Found by Oracle Parfait 13.3:
   Null pointer dereference [null-pointer-deref]:
      Read from null pointer XTestptr
        at line 274 of Xi/xichangehierarchy.c in function 'remove_master'.
          Null pointer introduced at line 691 of Xext/xtest.c in function
	   'GetXTestDevice'.
          Function GetXTestDevice may return constant 'NULL' at line 691,
	   called at line 273 of Xi/xichangehierarchy.c in function
	   'remove_master'.
   Null pointer dereference [null-pointer-deref]:
      Read from null pointer XTestkeybd
        at line 279 of Xi/xichangehierarchy.c in function 'remove_master'.
          Null pointer introduced at line 691 of Xext/xtest.c in function
	   'GetXTestDevice'.
          Function GetXTestDevice may return constant 'NULL' at line 691,
	   called at line 278 of Xi/xichangehierarchy.c in function
	   'remove_master'.

Fixes: 0814f511d ("input: store the master device's ID in the devPrivate for XTest devices.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1730>
 		2024-10-28 05:38:25 +00:00
..
XIstubs.h include: unexport XIstubs.h 2024-09-01 22:21:12 +00:00
allowev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
allowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgdctl.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgdctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgfctl.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgfctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgkbd.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgkbd.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgkmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgkmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgprop.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgprop.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
chgptr.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
chgptr.h Xi: Remove redundant declaration. 2012-05-14 13:17:30 +01:00
closedev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
closedev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
devbell.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
devbell.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
exevents.c dix: unexport non-public functions from dixgrabs.h and document prototypes 2024-10-10 13:50:57 +00:00
exglobals.h xinput: Remove PropagateMask 2020-03-30 21:48:11 +00:00
extinit.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getbmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getbmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getdctl.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getdctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getfctl.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getfctl.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getfocus.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getkmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getkmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getmmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getmmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getprop.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getprop.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getselev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getselev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
getvers.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
getvers.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
grabdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdevb.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
grabdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
grabdevk.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
grabdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
gtmotion.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
gtmotion.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
listdev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
listdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
meson.build Add a Meson build system alongside autotools. 2017-04-26 15:25:27 -07:00
opendev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
opendev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
queryst.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
queryst.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
selectev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
selectev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
sendexev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
sendexev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setbmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
setbmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setdval.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
setdval.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setfocus.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
setfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setmmap.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
setmmap.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
setmode.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
setmode.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
stubs.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
ungrdev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
ungrdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevb.c dix: unexport non-public functions from dixgrabs.h and document prototypes 2024-10-10 13:50:57 +00:00
ungrdevb.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
ungrdevk.c dix: unexport non-public functions from dixgrabs.h and document prototypes 2024-10-10 13:50:57 +00:00
ungrdevk.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiallowev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiallowev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xibarriers.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xibarriers.h Xi: free barrier code at reset time 2013-05-07 09:41:19 +10:00
xichangecursor.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xichangecursor.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xichangehierarchy.c Xi: avoid NULL pointer dereference if GetXTestDevice returns NULL 2024-10-28 05:38:25 +00:00
xichangehierarchy.h xinput: Silence a warning from gcc 11 2021-08-17 16:02:44 -04:00
xigetclientpointer.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xigetclientpointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xigrabdev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xigrabdev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xipassivegrab.c dix: unexport non-public functions from dixgrabs.h and document prototypes 2024-10-10 13:50:57 +00:00
xipassivegrab.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiproperty.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiproperty.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiquerydevice.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiquerydevice.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiquerypointer.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiquerypointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiqueryversion.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiqueryversion.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiselectev.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiselectev.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xisetclientpointer.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xisetclientpointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xisetdevfocus.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xisetdevfocus.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00
xiwarppointer.c drop obsolete HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
xiwarppointer.h Introduce a consistent coding style 2012-03-21 13:54:42 -07:00