frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
XLibre Xserver
12,976 Commits 293 Branches 13 Tags 61 MiB
C 96.4%
Roff 1.1%
Objective-C 1%
Meson 0.8%
Shell 0.2%
Other 0.3%
Go to file
Ben Gamari c1d30b5bd7 Xi: Don't ActivateEarlyAccept POINTER_REGULAR listeners 
Bug #71878 describes a bug resulting in the server ceasing to respond to
keyboard input after a touch event. The problem might be the following:

DeliverTouchBeginEvent tries to deliver an event to a listener of type
LISTENER_POINTER_REGULAR, taking the following if branch,

    if (listener->type == LISTENER_POINTER_REGULAR ||
        listener->type == LISTENER_POINTER_GRAB) {
        rc = DeliverTouchEmulatedEvent(dev, ti, ev, listener, client, win,
                                       grab, xi2mask);
        if (rc == Success) {
            listener->state = LISTENER_IS_OWNER;
            /* async grabs cannot replay, so automatically accept this touch */
            if (dev->deviceGrab.grab &&
                dev->deviceGrab.fromPassiveGrab &&
                dev->deviceGrab.grab->pointerMode == GrabModeAsync)
                ActivateEarlyAccept(dev, ti);
        }
        goto out;
    }

DeliverTouchEmulatedEvent succeeds.  The deviceGrab meets all
three of the conditions of the inner if, enters
ActivateEarlyAccept which then fails due to,

    BUG_RETURN(ti->listeners[0].type != LISTENER_GRAB &&
               ti->listeners[0].type != LISTENER_POINTER_GRAB);

That is, despite listener->type == LISTENER_POINTER_REGULAR. With my
non-existent knowledge of XINPUT, it seems like the solution here
might be to only ActivateEarlyAccept when listener->type ==
LISTENER_POINTER_GRAB.

Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
 		2013-12-11 14:00:50 +10:00
Xext damageext: Xineramify (v7) 2013-12-09 13:20:37 -05:00
Xi Xi: Don't ActivateEarlyAccept POINTER_REGULAR listeners 2013-12-11 14:00:50 +10:00
composite composite: Fix COW creation for Xinerama (v2) 2013-12-09 13:20:36 -05:00
config xserver: enable InputClass option "GrabDevice" by default for non-seat0 seats (#69478) 2013-09-25 03:52:54 +10:00
damageext damageext: Die if we can't create the Xinerama resource type 2013-12-09 13:20:37 -05:00
dbe dbe: Fold the window private private into the window private 2013-09-10 13:28:24 -04:00
dix bs: Set the screen's bs support level to WhenMapped 2013-12-09 13:20:36 -05:00
doc doc: Update documentation about Windows platforms support a bit 2012-10-29 12:21:14 +00:00
dri3 dri3: Disable when Xinerama is active 2013-12-09 13:20:36 -05:00
exa Stop including inline assembly .il file for Solaris Studio builds 2013-11-14 13:12:21 +09:00
fb fb: Remove unused compatibility wrappers 2013-09-10 13:29:21 -04:00
glx glx: Consistently use ARB-suffixed names for ARB_multitexture functions 2013-12-10 16:59:53 +00:00
hw hw/xwin/glx: Rewrite WGL wrappers after Xserver conversion to direct GL dispatch 2013-12-10 17:00:06 +00:00
include miext: Move SyncShm FDs out of the way of clients 2013-12-02 12:57:08 -08:00
m4 XORG_TLS: Pick the first option that works (ie: prefer __thread) 2013-02-14 09:20:47 -08:00
man Correct description of -displayfd option in man page. 2012-10-11 12:53:57 +01:00
mi mieq: Bump default queue size to 512 2013-11-14 16:35:32 +09:00
miext miext/sync: Handle libxshmfence API change 2013-12-02 12:57:11 -08:00
os miext: Move SyncShm FDs out of the way of clients 2013-12-02 12:57:08 -08:00
present present: Disable when Xinerama is active 2013-12-09 13:20:36 -05:00
pseudoramiX Move pseudoramiX code where it can be shared between Xwin and Xquartz 2013-08-30 12:52:30 +01:00
randr randr: deliver Output and Crtc events of attached output providers. 2013-10-30 08:09:31 -07:00
record Avoid conflicts with Solaris <sys/regset.h> defines that clash with our names 2013-11-12 21:03:53 +09:00
render Abstract cursor refcounting 2013-05-15 19:17:57 +10:00
test test: build the touch test only when building Xorg 2013-11-14 16:35:15 +09:00
xfixes fixes: Fix PanoramiXSetWindowShapeRegion for root windows (v2) 2013-12-09 13:20:37 -05:00
xkb xkb: don't call atoi(NULL) when parsing argv 2013-07-02 15:12:29 +10:00
.dir-locals.el Add .dir-locals.el 2013-08-17 12:17:36 +02:00
.gitignore doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00
COPYING Shadow: Switch the Amiga/Atari bitplane code to the canonical X.Org license 2013-05-14 14:41:00 -07:00
Makefile.am Add dri3 and present directorys to distribution 2013-11-01 01:45:22 -07:00
README packaging: provide a default README file #24206 2010-01-27 14:00:17 -08:00
autogen.sh autogen.sh: Honor NOCONFIGURE=1 2012-10-19 13:12:33 +10:00
configure.ac Bump version to 1.14.99.904 (1.15 RC4) 2013-12-10 10:29:11 -08:00
devbook.am devbook.am: maintenance update from docbook.am 2011-09-21 14:07:52 -07:00
docbook.am docbook.am: embed css styles inside the HTML HEAD element 2011-09-21 14:07:49 -07:00
fix-miregion Change region implementation names to eliminate the 'mi' prefix 2010-06-05 17:47:32 -07:00
fix-miregion-private Change region implementation names to eliminate the 'mi' prefix 2010-06-05 17:47:32 -07:00
fix-patch-whitespace Rename region macros to eliminate screen argument 2010-06-05 18:59:00 -07:00
fix-region Rename region macros to eliminate screen argument 2010-06-05 18:59:00 -07:00
manpages.am Xdmx.man: Show actual configured XKB defaults instead of old hardcoded values 2011-06-21 17:54:14 -07:00
xorg-server.m4 macros: clarify documentation 2012-11-05 13:24:57 -06:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

README 

					X Server

The X server accepts requests from client applications to create windows,
which are (normally rectangular) "virtual screens" that the client program
can draw into.

Windows are then composed on the actual screen by the X server
(or by a separate composite manager) as directed by the window manager,
which usually communicates with the user via graphical controls such as buttons
and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the
following article:
http://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the
Xorg mailing list:

        http://lists.freedesktop.org/mailman/listinfo/xorg

Please submit bug reports to the Xorg bugzilla:

        https://bugs.freedesktop.org/enter_bug.cgi?product=xorg

The master development code repository can be found at:

        git://anongit.freedesktop.org/git/xorg/xserver

        http://cgit.freedesktop.org/xorg/xserver

For patch submission instructions, see:

	http://www.x.org/wiki/Development/Documentation/SubmittingPatches

For more information on the git code manager, see:

        http://wiki.x.org/wiki/GitPage