frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
XLibre Xserver
16,834 Commits 293 Branches 13 Tags 61 MiB
C 96.4%
Roff 1.1%
Objective-C 1%
Meson 0.8%
Shell 0.2%
Other 0.3%
Go to file
Aaron Plattner cfc5e5040c modesetting: Check whether RandR was initialized before calling rrGetScrPriv 
Calling rrGetScrPriv when RandR isn't initialized causes an assertion
failure that aborts the server:

 Xorg: ../include/privates.h:121: dixGetPrivateAddr: Assertion `key->initialized' failed.

 Thread 1 "Xorg" received signal SIGABRT, Aborted.
 0x00007ffff78a8f25 in raise () from /usr/lib/libc.so.6
 (gdb) bt
 #0  0x00007ffff78a8f25 in raise () from /usr/lib/libc.so.6
 #1  0x00007ffff7892897 in abort () from /usr/lib/libc.so.6
 #2  0x00007ffff7892767 in __assert_fail_base.cold () from /usr/lib/libc.so.6
 #3  0x00007ffff78a1526 in __assert_fail () from /usr/lib/libc.so.6
 #4  0x00007ffff7fb57c1 in dixGetPrivateAddr (privates=0x555555ab1b60, key=0x555555855720 <rrPrivKeyRec>) at ../include/privates.h:121
 #5  0x00007ffff7fb5822 in dixGetPrivate (privates=0x555555ab1b60, key=0x555555855720 <rrPrivKeyRec>) at ../include/privates.h:136
 #6  0x00007ffff7fb586a in dixLookupPrivate (privates=0x555555ab1b60, key=0x555555855720 <rrPrivKeyRec>) at ../include/privates.h:166
 #7  0x00007ffff7fb8445 in CreateScreenResources (pScreen=0x555555ab1790) at ../hw/xfree86/drivers/modesetting/driver.c:1335
 #8  0x000055555576c5e4 in xf86CrtcCreateScreenResources (screen=0x555555ab1790) at ../hw/xfree86/modes/xf86Crtc.c:744
 #9  0x00005555555d8bb6 in dix_main (argc=4, argv=0x7fffffffead8, envp=0x7fffffffeb00) at ../dix/main.c:214
 #10 0x00005555557a4f0b in main (argc=4, argv=0x7fffffffead8, envp=0x7fffffffeb00) at ../dix/stubmain.c:34

This can happen, for example, if the server is configured with Xinerama
and there is more than one X screen:

 Section "ServerLayout"
   Identifier "crash"
   Screen 0 "modesetting"
   Screen 1 "dummy" RightOf "modesetting"
   Option "Xinerama"
 EndSection

 Section "Device"
   Identifier "modesetting"
   Driver "modesetting"
 EndSection

 Section "Screen"
   Identifier "modesetting"
   Device "modesetting"
 EndSection

 Section "Device"
   Identifier "dummy"
   Driver "dummy"
 EndSection

 Section "Screen"
   Identifier "dummy"
   Device "dummy"
 EndSection

The problem does not reproduce if there is only one X screen because of
this code in xf86RandR12Init:

 #ifdef PANORAMIX
     /* XXX disable RandR when using Xinerama */
     if (!noPanoramiXExtension) {
         if (xf86NumScreens == 1)
             noPanoramiXExtension = TRUE;
         else
             return TRUE;
     }
 #endif

Fix the problem by checking dixPrivateKeyRegistered(rrPrivKey) before
calling rrGetScrPriv. This is similar to what the xf86-video-amdgpu
driver does:
fd66f5c0be/src/amdgpu_kms.c (L388)

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com>
(cherry picked from commit 4226c6d032)
 		2020-01-13 22:11:10 +00:00
.gitlab-ci gitlab-ci: Add ccache to docker image, and leave in autotools 2019-02-22 11:55:31 +01:00
Xext os: Don't crash in AttendClient if the client is gone 2019-11-20 11:18:28 -08:00
Xi Xi: return AlreadyGrabbed for key grabs > 255 2020-01-09 16:18:28 -05:00
composite Switch automatic composite update to WorkQueue 2018-10-05 09:14:18 +02:00
config meson: Fix install path for 10-quirks.conf 2018-03-27 10:28:33 -04:00
damageext Use ARRAY_SIZE all over the tree 2017-10-30 13:45:20 -04:00
dbe meson: Distribute more SDK headers 2018-04-02 13:42:08 -04:00
dix os: Don't crash in AttendClient if the client is gone 2019-11-20 11:18:28 -08:00
doc mi: Add a default no-op miSourceValidate 2019-11-18 14:23:15 -05:00
dri3 dri3: Fix XACE access mode for open and get_supported_modifiers 2019-02-20 14:25:58 -05:00
exa exa: Use PictureMatchFormat for source-only picture format description 2018-06-19 09:52:17 -04:00
fb fboverlay: move bpp checks above malloc 2018-10-04 17:26:09 +02:00
glamor glamor: Add a function to get the driver name via EGL_MESA_query_driver 2019-11-26 21:57:17 -08:00
glx dix: Call SourceValidate before GetImage 2019-11-18 14:23:38 -05:00
hw modesetting: Check whether RandR was initialized before calling rrGetScrPriv 2020-01-13 22:11:10 +00:00
include glamor: Add a function to get the driver name via EGL_MESA_query_driver 2019-11-26 21:57:17 -08:00
m4 Add ax_pthread.m4 to m4/ 2016-05-29 19:20:51 -07:00
man man: s/__/@/g 2018-03-27 10:13:17 -04:00
mi mi: Add a default no-op miSourceValidate 2019-11-18 14:23:15 -05:00
miext miext/sync: Make struct _SyncObject::initialized fully ABI compatible 2019-09-26 18:26:45 +02:00
os os: Don't crash in AttendClient if the client is gone 2019-11-20 11:18:28 -08:00
present present/wnmd: Relax assertion on CRTC on abort_vblank() 2019-11-21 10:52:12 +01:00
pseudoramiX Unvalidated lengths 2017-10-10 23:33:34 +02:00
randr randr: Fix RRCrtcDetachScanoutPixmap() segfault during server teardown 2019-11-11 14:46:32 -08:00
record os: Don't crash in AttendClient if the client is gone 2019-11-20 11:18:28 -08:00
render dix: Call SourceValidate before GetImage 2019-11-18 14:23:38 -05:00
test test: Use .../piglit instead of .../piglit-*.py 2019-02-22 11:53:37 +01:00
xfixes xfixes: Restore monitoring of animated cursors 2018-02-14 13:52:45 -05:00
xkb Fix crash on XkbSetMap 2019-10-14 15:36:17 +10:00
.appveyor.yml appveyor: use meson 2018-03-21 10:16:44 -04:00
.dir-locals.el Add .dir-locals.el 2013-08-17 12:17:36 +02:00
.gitignore .gitignore: Add new autotools file 'test-driver' 2014-04-21 13:41:42 -07:00
.gitlab-ci.yml Revert "gitlab-ci: Only run docker-image stage if relevant source files change" 2019-03-25 12:45:52 +01:00
.travis.yml Drop Travis Linux build in favour of GitLab CI 2019-02-22 11:52:42 +01:00
COPYING modesetting: Merge modesetting's COPYING into the xserver's. 2014-09-15 12:46:02 -07:00
Makefile.am Update README for gitlab migration 2019-02-20 14:22:02 -05:00
README.md Update README for gitlab migration 2019-02-20 14:22:02 -05:00
autogen.sh autogen: Set a default subject prefix for patches 2016-02-08 17:41:38 -05:00
configure.ac xserver 1.20.6 2019-11-22 17:56:38 -05:00
devbook.am doc: Create a script to filter xmlto output 2015-01-05 14:24:06 -08:00
docbook.am docbook.am: embed css styles inside the HTML HEAD element 2011-09-21 14:07:49 -07:00
fix-miregion Change region implementation names to eliminate the 'mi' prefix 2010-06-05 17:47:32 -07:00
fix-miregion-private Change region implementation names to eliminate the 'mi' prefix 2010-06-05 17:47:32 -07:00
fix-patch-whitespace Rename region macros to eliminate screen argument 2010-06-05 18:59:00 -07:00
fix-region Rename region macros to eliminate screen argument 2010-06-05 18:59:00 -07:00
manpages.am man: Fix automake seddery 2018-05-08 12:15:30 -04:00
meson.build xserver 1.20.6 2019-11-22 17:56:38 -05:00
meson_options.txt meson: Add configuration of listening on tcp, unix and local 2018-08-01 11:01:37 -04:00
xorg-server.m4 macros: clarify documentation 2012-11-05 13:24:57 -06:00
xorg-server.pc.in xfree86: link modules against Xorg symbols on Cygwin 2012-04-05 21:57:07 -05:00
xserver.ent.in doc: relocate xserver.ent in the package root directory 2011-05-14 11:22:26 -07:00

README.md

X Server

The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.

Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.

For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server

All questions regarding this software should be directed at the Xorg mailing list:

https://lists.freedesktop.org/mailman/listinfo/xorg

The master development code repository can be found at:

https://gitlab.freedesktop.org/xorg/xserver

For patch submission instructions, see:

https://www.x.org/wiki/Development/Documentation/SubmittingPatches

As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc:

https://www.freedesktop.org/wiki/CodeOfConduct