frederik
/
xserver
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
xserver/dix
History
Enrico Weigelt, metux IT consult befc3d22cf dix: add per-screen pixmap destructor mechanism 
Right now, extension specific pixmap destruction procedures are implemented
by wrapping the ScreenRec's DestroyPixmap() proc pointer: the extensions are
storing the original pointer in their private data and putting in their own one.
On each call, their proc restores the original one, calls it, and switches back
again. When multiple extensions doing so, they're forming a kind of daisy chain.
(the same is done for lots of other procs)

While that approach is looking nice and elegant on the drawing board, it's
complicated, dangerous like a chainsaw and makes debugging hard, leading to
pretty blurred API borders.

It's even getting worse: the proc also has to do ref counting, and only destroy
the pixmap if refconter reaching zero - that's all done in the individual screen
drivers. Therefore, all extensions must check for refcnt == 1, in order to know
when to really act.

This commit introduces a simple approach for letting extension hook into the
pixmap destruction safely, w/o having to care much about side effects with
the call chain. Extensions now can simply register their destructor proc
(and an opaque pointer) and get called back - w/o ever having to mess with
the ScreenRec's internal structures.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
 		2025-06-12 16:46:30 +02:00
..
.gitignore Fix spelling/wording issues 2020-07-05 13:07:33 -07:00
BuiltInAtoms R6.6 is the Xorg base-line 2003-11-14 15:54:54 +00:00
atom.c dix: unexport InitAtoms() and FreeAllAtoms() 2025-06-12 16:20:15 +02:00
atom_priv.h dix: unexport InitAtoms() and FreeAllAtoms() 2025-06-12 16:20:15 +02:00
callback_priv.h dix: make DeleteCallbackList() non-static and document it 2025-06-12 16:43:56 +02:00
closestr.h dix: move closestr.h into dix directory 2024-04-16 01:42:39 +00:00
color.c dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
colormap.c dix: unexport DeliverEvents() and fix return type 2025-06-12 16:18:40 +02:00
colormap_priv.h dix: move colormap flags into colormap_priv.h and rename them 2024-09-01 22:06:50 +00:00
cursor.c dix: NULL-protect AllocGlyphCursor() 2025-06-12 16:34:37 +02:00
cursor_priv.h dix: unexport GetSpritePosition() 2024-09-02 16:43:29 +00:00
devices.c dix: devices: refine NULL checks in GetMaster() 2025-06-12 16:34:34 +02:00
dispatch.c dix: add per-screen pixmap destructor mechanism 2025-06-12 16:46:30 +02:00
dispatch.h dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
display.c dix: add getter for display name 2025-02-11 19:13:01 +01:00
dix_priv.h dix: add per-screen pixmap destructor mechanism 2025-06-12 16:46:30 +02:00
dixfonts.c dix: dixfonts: explain analyzer false alarm on alleged free() of stack chunk 2025-06-12 16:34:20 +02:00
dixgrabs_priv.h dix: unexport non-public functions from dixgrabs.h and document prototypes 2024-10-10 13:50:57 +00:00
dixstruct_priv.h include: move private defs to dixstruct_priv.h 2024-04-30 00:47:38 +00:00
dixutils.c dix: make DeleteCallbackList() non-static and document it 2025-06-12 16:43:56 +02:00
enterleave.c dix: protect against alloc failure in ‘DeviceFocusEvent() 2025-06-12 16:34:05 +02:00
enterleave.h dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
eventconvert.c dix: limit checks to MAX_VALUATORS when generating Xi events 2024-10-28 05:38:25 +00:00
eventconvert.h dix: unexport eventconvert.h functions 2024-03-11 12:26:44 +01:00
events.c dix: make DeviceEnterLeaveEvent() anaylzer-friendly 2025-06-12 16:34:29 +02:00
exevents_priv.h XI: unexport XIPropToInt() and XIPropToFloat() 2025-06-12 16:25:48 +02:00
extension.c dix: clear free()ed pointers on CloseDownExtensions() 2025-06-12 16:34:39 +02:00
gc.c dix: replace FreeDefaultStipple() 2025-06-12 16:43:51 +02:00
gc_priv.h dix: replace FreeDefaultStipple() 2025-06-12 16:43:51 +02:00
generate-atoms dix: replace AtomError() by better messages 2025-06-12 16:20:12 +02:00
gestures.c dix: NULL-protection in GestureAddRegularListener() 2025-06-12 16:34:17 +02:00
getevents.c dix: rename IsFloating() to InputDevIsFloating() 2025-06-12 16:19:40 +02:00
globals.c dix: add getter for display name 2025-02-11 19:13:01 +01:00
glyphcurs.c dix: use dixDestroyPixmap() instead of direct driver call 2025-02-12 17:48:30 +01:00
grabs.c dix: rename IsMaster to InputDevIsMaster() 2025-06-12 16:19:33 +02:00
input_priv.h dix: unexport LastEventTimeToggleResetAll() 2025-06-12 16:20:06 +02:00
inpututils.c dix: protect input_option_set_value() from NULL pointer 2025-06-12 16:34:47 +02:00
main.c dix: consolidate screen destruction in dixFreeScreen() 2025-06-12 16:43:54 +02:00
meson.build dix: add per-screen window destructor hook 2025-06-12 16:43:59 +02:00
pixmap.c dix: use dixDestroyPixmap() instead of direct driver call 2025-02-12 17:48:30 +01:00
privates.c dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
property.c dix: move props into WindowRec and fix potential NULL deref 2025-06-12 16:34:03 +02:00
property_priv.h dix: unexport DeleteAllWindowProperties() 2024-09-02 17:50:47 +00:00
protocol.txt drop remains of DMX 2024-03-05 16:57:52 +01:00
ptrveloc.c XI: unexport XIPropToInt() and XIPropToFloat() 2025-06-12 16:25:48 +02:00
ptrveloc_priv.h dix: fix duplicate typedef of MotionTracker and *MotionTrackerPtr 2024-09-01 22:32:49 +00:00
region.c dix: region: turn xfreeData() into inline func and add checks 2025-06-12 16:34:31 +02:00
registry.c dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
registry_priv.h dix: unexport XREGISTRY_UNKNOWN define 2024-03-03 23:20:06 +00:00
reqhandlers_priv.h dix: unexport events related request handlers 2025-06-12 16:16:45 +02:00
resource.c dix: unexport and document MarkClientException() 2025-06-12 16:17:42 +02:00
screen.c dix: add per-screen pixmap destructor mechanism 2025-06-12 16:46:30 +02:00
screen_hooks.c dix: add per-screen pixmap destructor mechanism 2025-06-12 16:46:30 +02:00
screen_hooks_priv.h dix: add per-screen pixmap destructor mechanism 2025-06-12 16:46:30 +02:00
screenint_priv.h dix: fix duplicate typedef of *ScreenPtr 2024-09-01 22:32:49 +00:00
selection.c dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
stubmain.c Allow DDX to provide a main() 2013-07-23 23:56:58 +01:00
swaprep.c dix: drop unnecessary check on HAVE_DIX_CONFIG_H 2024-10-10 13:38:31 +00:00
swapreq.c dix: unexport events related request handlers 2025-06-12 16:16:45 +02:00
tables.c include: drop obsolete dixevents.h 2025-06-12 16:17:35 +02:00
touch.c dix: touch: NULL-protection in TouchAddRegularListener() 2025-06-12 16:34:12 +02:00
window.c dix: add per-screen window position notify hook 2025-06-12 16:44:33 +02:00